Bug 104607

Summary: Mesa fails to build in OBS after c797cd605ac9cb42795a40b1967b6dd10184b763
Product: Mesa Reporter: network723
Component: Drivers/Gallium/radeonsiAssignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact: Default DRI bug account <dri-devel>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Don't look at me

Description network723 2018-01-12 18:39:26 UTC 
Created attachment 136691 [details] [review]
Don't look at me

Mesa fails to build with openSUSE build service after the commit c797cd605ac9cb42795a40b1967b6dd10184b763 with message 'I: Program returns random data in a function \n E: Mesa no-return-in-nonvoid-function si_shader.c:1967'

I had to make some changes to si_shader.c to make it build again, however I had no idea what I was doing.
Comment 1 Bas Nieuwenhuizen 2018-01-12 18:43:12 UTC 
This patch is on the list and probably fixes it:

https://patchwork.freedesktop.org/patch/197359/
Comment 2 network723 2018-01-12 19:22:53 UTC 
(In reply to Bas Nieuwenhuizen from comment #1)
> This patch is on the list and probably fixes it:
> 
> https://patchwork.freedesktop.org/patch/197359/

Thank you, it worked for me.
Comment 3 Timothy Arceri 2018-03-31 23:53:28 UTC 
Fixed by:

author	Mauro Rossi <issor.oruam@gmail.com>
commit	4d61eb80187cd8e5984eed94f2ae3c7d6c3b3aa0 (patch)

ac: fix build error in si_shader
assert() is replaced by unreachable(), to avoid following building error:

external/mesa/src/gallium/drivers/radeonsi/si_shader.c:1967:1:
error: control may reach end of non-void function [-Werror,-Wreturn-type]
}
^
1 error generated.

Fixes: c797cd6 ("ac: add load_patch_vertices_in() to the abi")

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.