Bug 104794

Summary: piglit.spec.arb_internalformat_query2.samples and num_sample_counts pname checks
Product: Mesa Reporter: Mark Janes <mark.a.janes>
Component: Drivers/DRI/i965Assignee: Juan A. Suarez <jasuarez>
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium Keywords: bisected, regression
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Mark Janes 2018-01-25 22:27:41 UTC 
Bisected to:
513c2263cbff45edb105c7b46e58f316e06746ab
Author:     Juan A. Suarez Romero <jasuarez@igalia.com>
mesa: add missing RGB9_E5 format in _mesa_base_fbo_format

This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

----------------------------
Standard Output

/tmp/build_root/m64/lib/piglit/bin/arb_internalformat_query2-samples-pnames -auto -fbo

Standard Error

    32 bit failing case: pname = GL_NUM_SAMPLE_COUNTS, target = GL_RENDERBUFFER, internalformat = GL_RGB9_E5, params[0] = (2,(unrecognized enum: 0x2)), supported=1
    32 bit failing case: pname = GL_NUM_SAMPLE_COUNTS, target = GL_TEXTURE_2D_MULTISAMPLE, internalformat = GL_RGB9_E5, params[0] = (2,(unrecognized enum: 0x2)), supported=1
    32 bit failing case: pname = GL_NUM_SAMPLE_COUNTS, target = GL_TEXTURE_2D_MULTISAMPLE_ARRAY, internalformat = GL_RGB9_E5, params[0] = (2,(unrecognized enum: 0x2)), supported=1
    64 bit failing case: pname = GL_NUM_SAMPLE_COUNTS, target = GL_RENDERBUFFER, internalformat = GL_RGB9_E5, params[0] = (2,(unrecognized enum: 0x2)), supported=1
    64 bit failing case: pname = GL_NUM_SAMPLE_COUNTS, target = GL_TEXTURE_2D_MULTISAMPLE, internalformat = GL_RGB9_E5, params[0] = (2,(unrecognized enum: 0x2)), supported=1
    64 bit failing case: pname = GL_NUM_SAMPLE_COUNTS, target = GL_TEXTURE_2D_MULTISAMPLE_ARRAY, internalformat = GL_RGB9_E5, params[0] = (2,(unrecognized enum: 0x2)), supported=1
    32 bit failing case: pname = GL_SAMPLES, target = GL_RENDERBUFFER, internalformat = GL_RGB9_E5, params[0] = (8,(unrecognized enum: 0x8)), supported=1
    32 bit failing case: pname = GL_SAMPLES, target = GL_TEXTURE_2D_MULTISAMPLE, internalformat = GL_RGB9_E5, params[0] = (8,(unrecognized enum: 0x8)), supported=1
    32 bit failing case: pname = GL_SAMPLES, target = GL_TEXTURE_2D_MULTISAMPLE_ARRAY, internalformat = GL_RGB9_E5, params[0] = (8,(unrecognized enum: 0x8)), supported=1
    64 bit failing case: pname = GL_SAMPLES, target = GL_RENDERBUFFER, internalformat = GL_RGB9_E5, params[0] = (8,(unrecognized enum: 0x8)), supported=1
    64 bit failing case: pname = GL_SAMPLES, target = GL_TEXTURE_2D_MULTISAMPLE, internalformat = GL_RGB9_E5, params[0] = (8,(unrecognized enum: 0x8)), supported=1
    64 bit failing case: pname = GL_SAMPLES, target = GL_TEXTURE_2D_MULTISAMPLE_ARRAY, internalformat = GL_RGB9_E5, params[0] = (8,(unrecognized enum: 0x8)), supported=1
Comment 1 Antia Puentes 2018-02-23 10:54:35 UTC 
This should be fixed now.

The commit originating the regressions was reverted by me, however, in issue  https://github.com/KhronosGroup/OpenGL-API/issues/32 it was clarified that the commit implemented the correct behaviour.

Commit is now restored in Mesa master and the regressions fixed in Piglit.

** Mesa **

commit e1623b303ccc7a880e34bddef7231dcf230826b3
Author: Juan A. Suarez Romero <jasuarez@igalia.com>
Date:   Mon Jan 15 10:58:50 2018 +0000

    mesa: add missing RGB9_E5 format in _mesa_base_fbo_format
    
    RGB9_E5 should be accepted by RenderbufferStorage if the
    EXT_texture_shared_exponent is exposed. It is left to the
    implementations to return GL_FRAMEBUFFER_UNSUPPORTED_EXT
    when checking the framebuffer completeness if they do not
    support rendering in this format.
    
    Discussed in:
    https://github.com/KhronosGroup/OpenGL-API/issues/32
    
    This fixes KHR-GL45.internalformat.renderbuffer.rgb9_e5
    
    v2: Added more info to the commit message (Antia)
    
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Antia Puentes <apuentes@igalia.com>

** Piglit **

commit 5f11fdff7b329eb5712eed98f783a6164410336f
Author: Antia Puentes <apuentes@igalia.com>
Date:   Tue Feb 20 13:55:13 2018 +0100

    internalformat_query*: fix SAMPLES pname checks for RGB9_E5

    SAMPLES and NUM_SAMPLE_COUNTS queries accept internalformats which
    are defined as color-, depth- or stencil-renderable. RGB9_E5 is marked
    as non color-renderable in OpenGL 4.6, however if the
    EXT_texture_shared_exponent extension is exposed it must be considered
    as such. The later was discussed in:
    https://github.com/KhronosGroup/OpenGL-API/issues/32
    
    v2: use 'tex' as shortname for texture instead of 'text' (Piñeiro)
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104794
    
    Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.