|Summary:||Old Hungarian letters missing|
|Product:||DejaVu||Reporter:||Kovács Viktor <kovacs.viktor.dev>|
|Component:||Sans||Assignee:||Deja Vu bugs <dejavu-bugs>|
|Status:||RESOLVED MOVED||QA Contact:|
|Priority:||high||CC:||fitojb, moyogo, nemeth, nemeth, nocturnaldreamer, rovasinfo, timar74, vstuart.foote|
|i915 platform:||i915 features:|
Old Hungarian patch for DejaVuSans base family
Test of first implementation of old hungarian sans family
As it looks like, the patch must be removed.
Testpage of Old Hungarian letters
My old hungarian letters in a table
Old Hungarian letters table with book and oblique
Old Hungarian table
Tests of normal and oblique form
Old Hungarian patch 0.1
Description Kovács Viktor 2018-02-17 17:19:22 UTC
Comment 1 Kovács Viktor 2018-02-17 17:28:20 UTC
From the DejaVu font family not yet adopted Old Hungarian letters (UNICODE range u+10c80-U+10cff.) How could I upload this part? What should I to do, if I grant font for this UNICODE-range? XKeyboard-config version 2.22 already have Old Hungarian keyboard layout.
Comment 2 Kovács Viktor 2018-02-19 08:27:23 UTC
@ moyogo Could You write me, how could I create and upload patch from a fontforge's file? Which license must I choose?
Comment 3 Kovács Viktor 2018-02-20 17:54:07 UTC
@ Denis Jacquerye I can use git commands in text-based files. My question is: how does it work with FontForge files at dejavu project?
Comment 4 nocturnaldreamer 2018-02-21 18:20:32 UTC
@Kovács Viktor: The license can be found both in the fonts themselves and on our website. Do I understand correctly, you designed glyphs for the Old Hungarian range and want to contribute them to the project? FontForge source files are just regular text file. What format is your contribution in?
Comment 5 Kovács Viktor 2018-02-22 11:01:25 UTC
(In reply to nocturnaldreamer from comment #4) > @Kovács Viktor: The license can be found both in the fonts themselves and on > our website. > > Do I understand correctly, you designed glyphs for the Old Hungarian range > and want to contribute them to the project? > > FontForge source files are just regular text file. What format is your > contribution in? Yes, I designed glyphs for the Old Hungarian range, and I would like to contribute them to the project, because: 1. "Rovás" community has more version of Old Hungarian range, but these are not perfectly designed as in UNICODE 8.0 standard described. (added nonstandard letters or developed to latin range) 2. LibreOffice Writer work with that range perfectly, LibreOffice cannot contribute fonts itself. 3. Now already exists in XKB Old-Hungarian keyboard layout, which is conform with UNICODE standard. So I would like to help users, who can not edit fonts, to use UNICODE conform Old Hungarian letters. SplineFontDB is 3.0, but I could not understand, what would you like to ask about what my format is contribution in. Thanks, Viktor
Comment 6 Kovács Viktor 2018-03-04 16:51:09 UTC
@Denis Jacquerye: When I would like to change the weight (generate light-weight and bold) which values must I choose in embolden em unit property?
Comment 7 Kovács Viktor 2018-03-12 04:07:38 UTC
I am working on it, it could happen it will be a little bit longer period.
Comment 8 Kovács Viktor 2018-03-30 10:12:46 UTC
Created attachment 138442 [details] [review] Old Hungarian patch for DejaVuSans base family In dis patch are added Old Hungarian letters for DejaVuSans normal, bold, oblique, bold Oblique and extra-light versions. Serif versions are impossible, because Old Hungarian letters are "runic" like letters. @moyogo: Please check it. If I have mistakes, tell me, which fonts have. If it acceptable, add it to repo, please! Viktor
Comment 9 Kovács Viktor 2018-03-31 07:49:15 UTC
Unicode Old Hungarian part: https://unicode.org/charts/PDF/U10C80.pdf
Comment 10 Kovács Viktor 2018-04-04 17:12:19 UTC
@ moyogo: @ nocturnaldreamer: So, there is a patch. For testing would be better the origin files of Old Hungarian lettres, or the patch is enought?
Comment 11 Kovács Viktor 2018-04-05 07:57:14 UTC
Created attachment 138615 [details] Test of first implementation of old hungarian sans family I tested myself. Latin characters seems little bit larger than the old hungarian one. I designed the letters with same height as in latin. What did I wrong?
Comment 12 Kovács Viktor 2018-04-06 17:41:49 UTC
Created attachment 138659 [details] As it looks like, the patch must be removed. Sorry about it! First I will thinking, before create a patch, I promisse.
Comment 13 Kovács Viktor 2018-05-31 13:04:31 UTC
Created attachment 139885 [details] Testpage of Old Hungarian letters This is the base letters testpage, just I drop in. I resolved form, readibility and rendering problems. @ moyogo! Acceptable? Should I work based on It? Viktor
Comment 14 Kovács Viktor 2018-06-02 12:46:07 UTC
Created attachment 139970 [details] My old hungarian letters in a table There is the tableform testpage, formed as UNICODE's table range 10c80-10cff. Origin is https://unicode.org/charts/PDF/U10C80.pdf
Comment 15 Kovács Viktor 2018-06-03 09:11:27 UTC
Created attachment 139984 [details] Old Hungarian letters table with book and oblique So, I working.
Comment 16 Kovács Viktor 2018-06-03 09:13:43 UTC
Created attachment 139985 [details] Old Hungarian table Sorry, previously upload the wrong file
Comment 17 Kovács Viktor 2018-07-11 12:14:12 UTC
Created attachment 140558 [details] Tests of normal and oblique form I am standardized fonts metrics with the DejaVu metrics. (linewidth, letters height, line angles. For example letters Old Hungarian L,G,S based on latin letter A.
Comment 18 Kovács Viktor 2018-07-19 07:35:51 UTC
Created attachment 140706 [details] [review] Old Hungarian patch 0.1 This patch hasn't got any rendering problems. I developed it carefully. Visibility, readibility, standard forms of letters, compatibility with DejaVu letters form are as good as it possible. The patch consists Old Hungarian letters for DejaVu Sans book, oblique, bold, bold oblique and extra light styles. Please adopt it!
Comment 19 László Németh 2018-07-19 08:05:38 UTC
@Viktor, could you send your patch to upstream DejaVu, too? This could help Linux distributions and other DejaVu users to use Old Hungarian characters. There are already other DejaVu improvements there for LibreOffice, waiting for merging. It's possible to collect all them for LibreOffice in a fork, if we don't want to wait for the upstream merge, and LibreOffice update (this is really a better solution, than a huge patch for LibreOffice). For example, https://bugs.freedesktop.org/show_bug.cgi?id=106488 and its upstream patch: https://github.com/dejavu-fonts/dejavu-fonts/pull/21 Thanks, László
Comment 20 Kovács Viktor 2018-07-19 13:02:11 UTC
@moyogo, @László: I have been uploaded patch file to github account dejavu, but I don't think, I did it correctly.
Comment 21 Kovács Viktor 2018-07-20 06:29:29 UTC
Upload is done, pull request #23
Comment 22 Kovács Viktor 2018-07-22 00:30:41 UTC
(In reply to László Németh from comment #19) > @Viktor, could you send your patch to upstream DejaVu, too? This could help > Linux distributions and other DejaVu users to use Old Hungarian characters. > There are already other DejaVu improvements there for LibreOffice, waiting > for merging. It's possible to collect all them for LibreOffice in a fork, if > we don't want to wait for the upstream merge, and LibreOffice update (this > is really a better solution, than a huge patch for LibreOffice). > > For example, > > https://bugs.freedesktop.org/show_bug.cgi?id=106488 > > and its upstream patch: > > https://github.com/dejavu-fonts/dejavu-fonts/pull/21 > > Thanks, László @László:Upload is done, but I don't understand, what does "open pull request' mean. When will be closed?
Comment 23 László Németh 2018-07-22 12:30:26 UTC
(In reply to Kovács Viktor from comment #22) > @László:Upload is done, but I don't understand, what does "open pull > request' mean. When will be closed? It depends of the decision/free time of maintainer of the font. We have enough time for the next big release, LibreOffice 6.2, to update the font in it, but if it's urgent, you can create and update a fork using your and the other fixes for LibreOffice and push a LibreOffice patch with it to gerrit, or ask help from the font maintainer or here, to do that. But I think, your work is on the right way to be in LibreOffice without forking, too.
Comment 24 Kovács Viktor 2018-07-27 07:58:03 UTC
@ nocturnaldreamer: If you have a free time, please check me, wheter my modifications mergeable or not. First time I uploaded patch files, but it have problems, as Alfredo wrote me. I beginner in Github. I removed the patches, and uploaded the modified files. If it is not mergeable, please explain me step by step, what need I to do. My pull request is https://github.com/dejavu-fonts/dejavu-fonts/pull/25 I removed #23 and #24, because there have only patches with problems, I do not know why. I can regenerate patch for it. Thanks: Viktor
Comment 25 Kovács Viktor 2018-07-29 06:48:29 UTC
@moyogo: The Old Hungarian part is ready for merging on github. Today I got an e-mail from a hungarian person, his name is Gyula Zsirgi, that he would like to use old-hungarian font. So, I would like to ask you again, merge it, when you have a free time. Please, write me, if it has problems again. It had problems previously.
Comment 26 Kovács Viktor 2018-08-06 13:18:07 UTC