Bug 105163

Summary: *-symbol-checks hard-code the nm executable
Product: DRI Reporter: Timo Gurr <timo.gurr>
Component: libdrmAssignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: XOrg git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
libdrm-symbol-check-Don-t-hard-code-nm-executable.patch none

Description Timo Gurr 2018-02-19 14:34:43 UTC 
Created attachment 137439 [details] [review]
libdrm-symbol-check-Don-t-hard-code-nm-executable.patch

Currently the *-symbol-checks hard-code the nm executable which may result in build failures when using a prefixed toolchain, e.g. /usr/x86_64-pc-linux-gnu/bin/x86_64-pc-linux-gnu-nm.

There was a patch suggested in 2016 and sent to the mailing list but it hasn't been fixed yet:

https://lists.freedesktop.org/archives/dri-devel/2016-October/119999.html

Attached is the patch in question for the sake of completeness.

It would be nice to get this fixed upstream.
Comment 1 Eric Engestrom 2018-02-26 15:18:13 UTC 
Fixed as of:

commit 4f08bfe96da1542f336589edf310d06ebce3cf20
Author: Heiko Becker <heirecka@exherbo.org>
Date:   Mon Feb 19 15:13:15 2018 +0000

    *-symbol-check: Don't hard-code nm executable
    
    Helpful if your nm executable has a prefix based on the
    architecture, for example.
    
    Signed-off-by: Heiko Becker <heirecka@exherbo.org>
    Cc: Timo Gurr <timo.gurr@gmail.com>
    [Eric: v2: rebase and add Meson support]
    Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>
    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.