Bug 105259

Summary:	Reversed rendering of selected text
Product:	poppler	Reporter:	Jason Crain <jason>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	jason
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Purchase Ledger Due Date Report (Detailed).pdf TextPage: Add horizontal scaling to font matrix text selection rendering without patch text selection rendering with patch

Description Jason Crain 2018-02-26 19:29:47 UTC

Created attachment 137618 [details]
Purchase Ledger Due Date Report (Detailed).pdf

Forwarding from https://bugzilla.gnome.org/show_bug.cgi?id=783954

---
On using cursor selection of text, the hi-lit text is rendered mirrored.
Using ^C to copy gives the correct text if pasted into another application.
evince --version: GNOME Document Viewer 3.22.1 (from Debian testing distribution)

Comment 1 Jason Crain 2018-02-26 19:31:28 UTC

Created attachment 137619 [details] [review]
TextPage: Add horizontal scaling to font matrix

Drawing the text selection sometimes draws text reversed or expanded.
This is because the while the current font transformation matrix is
saved, the horizontal scaling is not. Include the effect of the
horizontal scaling in the transformation matrix.

Comment 2 Jason Crain 2018-02-26 19:36:47 UTC

Created attachment 137620 [details]
text selection rendering without patch

without this patch, selected text is drawn reversed

Comment 3 Jason Crain 2018-02-26 19:37:33 UTC

Created attachment 137621 [details]
text selection rendering with patch

with patch, selected text is drawn correctly

Comment 4 Carlos Garcia Campos 2018-03-04 09:23:10 UTC

Pushed, thank you

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.