Bug 105444

Summary:	Enable GL disk shader cache when transform feedback is enabled
Product:	Mesa	Reporter:	Jordan Justen <jljusten>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	enhancement
Priority:	medium	CC:	eero.t.tamminen, jljusten, lemody, t_arceri
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Jordan Justen 2018-03-12 01:38:05 UTC

The Mesa shader cache core support and drivers prevent shader cache
usage when a shader program uses transform feedback.

We should try to remove this restriction for performance reasons,
and to simplify some code paths, by removing the need to check
for transform feedback.

Comment 1 Jordan Justen 2018-03-12 23:11:31 UTC

From irc, Tim mentions that we need to add
prog->TransformFeedback->VaryingNames into the sha1 in
shader_cache_read_program_metadata. Similar to 
AttributeBindings.

Comment 2 Jordan Justen 2018-03-19 18:00:03 UTC

Should be fixed by these commits:

commit 6d830940f78109db44293d41e74d9ec0a47da49b
glsl/shader_cache: Allow shader cache usage with transform feedback

commit fc4a7aaa8297370ba505b306b91a71a3b8545d18
i965: Allow disk shader cache usage with transform feedback

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.