| Summary: | [CI] igt@kms_frontbuffer_tracking@fbc* - fail - Failed assertion: !fbc_wait_until_enabled() | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Marta Löfstedt <marta.lofstedt> |
| Component: | DRM/Intel | Assignee: | Maarten Lankhorst <bugs> |
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | intel-gfx-bugs |
| Version: | DRI git | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=105520 | ||
| Whiteboard: | ReadyForDev | ||
| i915 platform: | CFL, CNL, GLK, ILK, KBL, SKL | i915 features: | display/FBC |
|
Description
Marta Löfstedt
2018-03-14 13:26:01 UTC
I pulled it out from the generic FBC disabled bug 101623 since it looks like a regression caused these test to fail on every run so far. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3912/commits.log has: commit caa1fd660e6f6701255544a3586a498676527fa4 Author: Rodrigo Vivi <rodrigo.vivi@intel.com> Date: Thu Mar 8 16:52:18 2018 -0800 drm/i915/psr: Display WA 0884 applied broadly for more HW tracking. So, I assign this bug to Rodrigo with a question if above commit may have caused this issue. Out GLk-shards have eDP PSR displays. A funny coincidence, but this is a regression on igt. DK couldn't reproduce on his machine so I asked him to update igt and retry so he started seeing the issues. bisect pending but suspicious is around: tests/kms_frontbuffer_tracking: Reduce fbc status spam, v2. tests/kms_frontbuffer_tracking: Respect mode when collecting CRCs. tests/kms_frontbuffer_tracking: Convert test to use igt_display, v3. igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc starts breaking with commit 8732f0ac3bda3ea32b32fa935e5681600e186c88 (HEAD) Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Date: Fri Feb 23 18:43:51 2018 +0100 tests/kms_frontbuffer_tracking: Convert test to use igt_display, v3. Straight conversion, no behavioral changes yet. Changes since v1: - Handle 2x outputs correctly. Changes since v2: - Set correct parameters in set_mode_for_params, so atomic commit for 2x outputs doesn't scale. - Fix accidental scaling in set_prim_plane_for_params. *** Bug 105520 has been marked as a duplicate of this bug. *** I confirm the bisect. I can reproduce on a HSW Harrisbeach laptop. It appear to only affect the badformat_subtest, and only on machines with eDP. And fixed, culprit was a modeset in setup_sink_crc() overwriting things.. https://patchwork.freedesktop.org/series/41273/ Fixed by: commit 8cc6f71c8afd6948723d577b9dd810d42a2fdacd Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Date: Fri Apr 6 14:42:01 2018 +0200 kms_frontbuffer_tracking: Remove unnecessary modeset from get_sink_crc. get_sink_crc() wants the eDP panel enabled to collect a CRC, but this is already required for opening the pipe CRC. This was broken in the conversion to igt_display, because the call to setup_sink_crc was moved. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> results are green on IGT_4416 after the patch was integrated I will close and archive. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.