Bug 105519

Summary:	[CI] igt@kms_frontbuffer_tracking@psr* - Failed assertion: psr_is_enabled() - CRITICAL: PSR still disabled
Product:	DRI	Reporter:	Marta Löfstedt <marta.lofstedt>
Component:	DRM/Intel	Assignee:	Marta Löfstedt <marta.lofstedt>
Status:	CLOSED FIXED	QA Contact:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity:	normal
Priority:	medium	CC:	intel-gfx-bugs
Version:	DRI git
Hardware:	Other
OS:	All
Whiteboard:	ReadyForDev
i915 platform:	CFL, CNL	i915 features:	display/PSR

Description Marta Löfstedt 2018-03-15 12:15:15 UTC

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-move.html

(kms_frontbuffer_tracking:1564) CRITICAL: Test assertion failure function do_status_assertions, file ../tests/kms_frontbuffer_tracking.c:1745:
(kms_frontbuffer_tracking:1564) CRITICAL: Failed assertion: psr_is_enabled()
(kms_frontbuffer_tracking:1564) CRITICAL: PSR still disabled
Subtest psr-2p-primscrn-spr-indfb-move failed.

The result from the test is similar to bug 103345. GHowever, the theory about that bug is that it is due to unsupported PSR display. This machines does not have the same display therfore I create a new bug

Comment 1 Marta Löfstedt 2018-03-15 12:19:14 UTC

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-move.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-mmap-cpu.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-msflip-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-msflip-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-pgflip-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-indfb-plflip-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt.html

Comment 2 Marta Löfstedt 2018-03-15 12:28:03 UTC

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-suspend.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-suspend.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-slowdraw.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-slowdraw.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-slowdraw.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb565-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-wc.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-wc.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-rgb565-draw-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb565-draw-blt.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cnl-y3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-s2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-cfl-u/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html

Comment 3 Marta Löfstedt 2018-03-15 12:30:40 UTC

I will not spam this bug with more data links.

All affected test and machines will be visible from:

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip.html
and:
https://intel-gfx-ci.01.org/cibuglog/

Comment 4 Marta Löfstedt 2018-03-15 13:18:50 UTC

The weird thing is that we didn't hit this so massively on the previous run we did with shards testlist on the BAT machines which was CI_DRM_3903.
So, now I am wondering if this is a duplicate of bug 105503, the patch I am wondering about on that bug was included on CI_DRM_3012

Comment 5 Rodrigo Vivi 2018-03-15 22:31:40 UTC

This one here is a regression caused by the removal of a PSR information
from debugfs 
be74229bd545 ("drm/i915/psr: Remove PSR active flag from debugfs")

a change on igt will be more appropriated. DK is going to check.

Comment 6 Maarten Lankhorst 2018-03-16 16:36:28 UTC

https://patchwork.freedesktop.org/series/40070/

Comment 7 Dhinakaran Pandiyan 2018-03-20 17:07:53 UTC

Maarten pushed this fix

commit 178e7f3da66cd02660a86257df75708a0efa3bbc
Author: Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>
Date:   Thu Mar 15 18:21:18 2018 -0700

    tests/kms_frontbuffer_tracking: Update check for PSR status


Can this be closed?

Comment 8 Marta Löfstedt 2018-03-21 06:45:38 UTC

Thanks for the fix, I will take the bug while waiting for the next drmtip run on the BAT machines. If it pass I will close.

Comment 9 Jani Saarinen 2018-03-21 07:28:21 UTC

Setting resolved to wait testing.

Comment 10 Marta Löfstedt 2018-03-23 08:00:53 UTC

Results looks green on drmtip_6, I will close and archive.

Comment 11 Marta Löfstedt 2018-03-27 11:44:07 UTC

Note, the enable_psr=1 option is now removed for the Ci system.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.