Bug 105633

Summary: [amdgpu][bisected] PRIME stuttering tearing
Product: DRI Reporter: Mike Lothian <mike>
Component: DRM/AMDgpuAssignee: Christian König <ckoenig.leichtzumerken>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: ckoenig.leichtzumerken, mike
Version: XOrg git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Possible fix none

Description Mike Lothian 2018-03-20 20:53:18 UTC 
I've bisected this to:

commit 9021d2edd259d992cf8b5b48791ab50829129de7                                                                                                                                                                                                               
Author: Christian König <christian.koenig@amd.com>                                                                                                                                                                                                            
Date:   Mon Feb 19 11:29:35 2018 +0100                                                                                                                                                                                                                        
                                                                                                                                                                                                                                                              
    drm/amdgpu: mitigate workaround for i915                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                              
    To be able to use DRI_PRIME with amdgpu and i915 we add all our fences                                                                                                                                                                                    
    only as exclusive ones.                                                                                                                                                                                                                                   
                                                                                                                                                                                                                                                              
    Disable that behavior when sharing between amdgpu itself cause it                                                                                                                                                                                         
    hinders concurrent execution.                                                                                                                                                                                                                             
                                                                                                                                                                                                                                                              
    Signed-off-by: Christian König <christian.koenig@amd.com>                                                                                                                                                                                                 
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>                                                                                                                                                                                                     
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>   

If I revert that and a bit of:

commit 59dd47728625e6f8e77f888d00596c9fb7057540
Author: Christian König <christian.koenig@amd.com>
Date:   Tue Feb 20 19:51:02 2018 +0100

    drm/amdgpu: further mitigate workaround for i915
    
    Disable the workaround on imported BOs as well.
    
    Signed-off-by: Christian König <christian.koenig@amd.com>
    Reviewed-by: Alex Deucher <alexdeucher@amd.com>                                                                                                                                                                                                           
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>   

To work around the compilation issue, things go back to normal
Comment 1 Christian König 2018-03-21 13:00:30 UTC 
Created attachment 138243 [details] [review]
Possible fix

Thanks for the report and yes I mixed up exporter and importer in the check.

Please test the attached patch.
Comment 2 Mike Lothian 2018-03-21 13:11:12 UTC 
That indeed fixes things for me

Tested-by: Mike Lothian <mike@fireburn.co.uk>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.