| Summary: | xmessage gets its widget hierarchy wrong [patch included] | ||
|---|---|---|---|
| Product: | xorg | Reporter: | Brice Goglin <brice.goglin> |
| Component: | App/other | Assignee: | Matthieu Herrb <matthieu.herrb> |
| Status: | RESOLVED NOTABUG | QA Contact: | Xorg Project Team <xorg-team> |
| Severity: | normal | ||
| Priority: | medium | CC: | matthieu.herrb |
| Version: | git | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=94713 | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
Hmm this report really lack details. Can you at least give us an url to the Debian BTS entry? I entered it in the "URL" field above, I don't know whether I am actually supposed to do so :) http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=94713 However, I already copied almost everything from the Debian BTS into here. And since the submitter's address isn't invalid anymore, we won't be able to help you more. I thought such a simple patch would look obviously wrong or obviously correct to somebody knowing Xt well... oops I did't look closely(In reply to comment #2) > I entered it in the "URL" field above, I don't know whether I am actually > supposed to do so :) > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=94713 Sorry I didn't look to the PR closely enough. > > However, I already copied almost everything from the Debian BTS into here. And > since the submitter's address isn't invalid anymore, we won't be able to help > you more. > > I thought such a simple patch would look obviously wrong or obviously correct > to somebody knowing Xt well... > It looks strange to me, causes an extra vertical space to be added below the text in the few test cases I did, and I still don't understand what problem this patch is supposed to fix. Xt applications can behave stupidly with stupid resources, so I'm more inclined to label this as an user error than as a real problem that needs a patch. Ok, then, go ahead and close it. I'll close the Debian bug too. If the submitter ever wakes up or if anybody else gets the same problem, I will tell him to come here. Sorry for the noise. Brice |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
According to M.Buckett in the Debian BTS 6 years ago, the following patch should be applied to xmessage (apparently still applies to git): < XtVaSetValues(text, XtNwidth, width, XtNheight, height, NULL); --- > XtVaSetValues(XtParent(text), XtNwidth, width, XtNheight, height, NULL); The submitter's address isn't valid anymore, but I guess you people will be able to see whethr he was right or not. Here's the explanation is give. xmessage [...] seemed to have a problem displaying a message. All I would get was a white empty box and the Okay message but the box was the correct size for the text. I discovered that this was due to my Xresources setup as clearing them displayed the message correctly. No matter how I tried I did not seem to be able to keep my Xresources and have xmessage work. Looking at the source and comparing it with xmotd (both use asciiTextWidget) I discovered that xmessage made a different call to set the values of the widget, so I made xmessage the same and hey presto it works. I'm no X programmer so I'm not sure how correct this is but it seems to work.