| Summary: | glsl_types.cpp(524): error: a dynamically-initialized local static variable is not allowed inside of a statement expression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | mesa-dev |
| Severity: | critical | ||
| Priority: | high | CC: | robclark, t_arceri |
| Version: | git | Keywords: | bisected, regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
It's not just intel c++, appveyor also complained. Fixed by: commit 1e0a06000bae17e1791f55127e7527946e9b6793 Author: Rob Clark <robdclark@gmail.com> Date: Mon Mar 26 18:45:07 2018 -0400 glsl_types: fix build break with intel/msvc compiler The VECN() macro was taking advantage of a GCC specific feature that is not available on lesser compilers, mostly for the purposes of avoiding a macro that encoded a return statement. But as suggested by Ian, we could just have the macro produce the entire method body and avoid the need for this. So let's do that instead. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105740 Fixes: f407edf3407396379e16b0be74b8d3b85d2ad7f0 Cc: Emil Velikov <emil.velikov@collabora.com> Cc: Timothy Arceri <tarceri@itsqueeze.com> Cc: Roland Scheidegger <sroland@vmware.com> Cc: Ian Romanick <idr@freedesktop.org> Signed-off-by: Rob Clark <robdclark@gmail.com> Acked-by: Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Intel C++ Compiler build error glsl_types.cpp(524): error: a dynamically-initialized local static variable is not allowed inside of a statement expression return VECN(components, float, vec); ^ commit f407edf3407396379e16b0be74b8d3b85d2ad7f0 Author: Rob Clark <robdclark@gmail.com> Date: Mon Mar 12 14:54:56 2018 -0400 glsl_types: refactor/prep for vec8/vec16 Refactor things so there isn't so much typing involved to add new things. Also drops a pointless conditional (out of bounds rows or columns already returns error_type in all paths.. might as well drop it rather than make the check more convoluted in the next patch by adding the vec8/vec16 case). Signed-off-by: Rob Clark <robdclark@gmail.com> Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>