Bug 105784

Summary:	mesa-18.0.0/src/intel/vulkan/anv_nir_apply_pipeline_layout.c:150: bad assert ?
Product:	Mesa	Reporter:	dcb314
Component:	Other	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	normal
Priority:	medium
Version:	17.3
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description dcb314 2018-03-28 11:22:36 UTC

[mesa-18.0.0/src/intel/vulkan/anv_nir_apply_pipeline_layout.c:150]: (style) Same expression on both sides of '&&'.

Source code is

   assert(intrin->src[0].is_ssa && intrin->src[0].is_ssa);

maybe better code

   assert(intrin->src[0].is_ssa && intrin->src[1].is_ssa);

Comment 1 Lionel Landwerlin 2018-03-28 11:39:06 UTC

Thanks, this was fixed recently in commit :

commit 0cc7370733e9d20999d13c4c8565f0c91846a45c
Author: Grazvydas Ignotas <notasas@gmail.com>
Date:   Tue Jan 23 00:44:36 2018 +0200

    anv: correct a duplicate check in an assert

I don't think we'll bother to cherry pick it back to 17.3 as it's not critical.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.