Bug 105817

Summary:	scons build broken by glSpecializeShaderARB
Product:	Mesa	Reporter:	Mark Janes <mark.a.janes>
Component:	Mesa core	Assignee:	Alejandro Piñeiro (freenode IRC: apinheiro) <apinheiro>
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	normal
Priority:	medium	CC:	elima, nhaehnle, nroberts
Version:	git	Keywords:	bisected, regression
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Mark Janes 2018-03-30 12:14:05 UTC

build/linux-x86_64-debug/mesa/libmesa.a(glspirv.os): In function `_mesa_SpecializeShaderARB':
mesa/src/mesa/main/glspirv.c:170: undefined reference to `gl_spirv_validation'

Bisected to:
ba975140d3c99b60c63846c3c08bd158f7c95d42 is the first bad commit
commit ba975140d3c99b60c63846c3c08bd158f7c95d42
Author: Nicolai Hähnle <nicolai.haehnle@amd.com>
Date:   Sat Jun 10 21:36:24 2017 +0200
    mesa: Implement glSpecializeShaderARB
    
    v2:
      * Use gl_spirv_validation instead of spirv_to_nir.  This method just
        validates the shader. The conversion to NIR will happen later,
        during linking. (Alejandro Piñeiro)
      * Use gl_shader_spirv_data struct to store the SPIR-V data.
        (Eduardo Lima)
      * Use the 'spirv_data' member to tell if the gl_shader is a SPIR-V
        shader, instead of a dedicated flag. (Timothy Arceri)
    
    Signed-off-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
    Signed-off-by: Alejandro Piñeiro <apinheiro@igalia.com>
    Signed-off-by: Eduardo Lima Mitev <elima@igalia.com>
    
    Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>

Comment 1 Neil Roberts 2018-03-30 15:13:47 UTC

I posted a patch for this. Any comments from someone experienced with SCons would be much appreciated.

https://patchwork.freedesktop.org/patch/214058/

Comment 2 Alejandro Piñeiro (freenode IRC: apinheiro) 2018-03-30 18:05:43 UTC

Brian Paul has just sent a series, with Neil's patch, plus some extra to get it working on MSVC:
https://lists.freedesktop.org/archives/mesa-dev/2018-March/190597.html

Comment 3 Brian Paul 2018-03-30 20:39:28 UTC

Should be fixed as of 26bc983c8374fd98dc3b8f8fa273f3063e3ac249 with the patch series by Neil and myself.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.