Bug 105990

(In reply to Martin Peres from comment #0)
> https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4422_full/shard-glkb4/
> igt@gem_eio@in-flight-immediate.html

404

Sorry, here is the real URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4422/shard-glkb4/igt@gem_eio@in-flight-immediate.html

Hmm, it *is* reporting that is not currently master (I had thought that was a silent return). However, it really, really should be master at that point, that implies something else is and this test should be the only client...

I agree. Maybe we could print the list of the clients when this fails? Bonus points for showing which one is actually master?

We do for set_master, but not drop as I didn't think it failed for !master!!

commit b7432bf309d5d5a6e07e8a0d8b522302fb0b4502 (HEAD, origin/master, origin/HEA
D)
Author: Katarzyna Dec <katarzyna.dec@intel.com>
Date:   Tue May 15 10:40:55 2018 +0200

    lib/igt_device: Add information why cannot drop drm master
    
    Let's add additional information to igt_device_drop_master
    in case we try to run tests with e.g. x11 enabled.
    
    v2: Changed comment and added listing clients.
    v3: Changed igt_require to igt_assert.
    v4: Added checking if we are master already.
    
    References: https://bugs.freedesktop.org/show_bug.cgi?id=105990
    Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Will prevent it happening again, but not actually answer who went rogue.

(In reply to Chris Wilson from comment #6)
> commit b7432bf309d5d5a6e07e8a0d8b522302fb0b4502 (HEAD, origin/master,
> origin/HEA
> D)
> Author: Katarzyna Dec <katarzyna.dec@intel.com>
> Date:   Tue May 15 10:40:55 2018 +0200
> 
>     lib/igt_device: Add information why cannot drop drm master
>     
>     Let's add additional information to igt_device_drop_master
>     in case we try to run tests with e.g. x11 enabled.
>     
>     v2: Changed comment and added listing clients.
>     v3: Changed igt_require to igt_assert.
>     v4: Added checking if we are master already.
>     
>     References: https://bugs.freedesktop.org/show_bug.cgi?id=105990
>     Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
>     Cc: Chris Wilson <chris@chris-wilson.co.uk>
>     Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Will prevent it happening again, but not actually answer who went rogue.

Great, thanks!