| Summary: | [CI] igt@drv_selftest@mock_breadcrumbs - breadcrumbs returned 10000, conflicting with selftest's magic values! | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Martin Peres <martin.peres> |
| Component: | DRM/Intel | Assignee: | Francesco Balestrieri <francesco.balestrieri> |
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | normal | ||
| Priority: | highest | CC: | intel-gfx-bugs |
| Version: | XOrg git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | ReadyForDev | ||
| i915 platform: | ALL | i915 features: | GEM/Other |
| Bug Depends on: | |||
| Bug Blocks: | 106319 | ||
|
Description
Martin Peres
2018-04-16 18:01:54 UTC
This comes with the new 4.17.0-rc1, so it is likely a core regression. For reference, commit d224985a5e312ab05b624143a3fd9bb91b53e52a Author: Peter Zijlstra <peterz@infradead.org> Date: Thu Mar 15 11:41:39 2018 +0100 sched/wait, drivers/drm: Convert wait_on_atomic_t() usage to the new wait_var_event() API The old wait_on_atomic_t() is going to get removed, use the more flexible wait_var_event() API instead. Unlike wake_up_atomic_t(), wake_up_var() will issue the wakeup even if the variable is not 0. No change in functionality. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: David Airlie <airlied@linux.ie> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-kernel@vger.kernel.org Signed-off-by: Ingo Molnar <mingo@kernel.org> did impact upon mock_breadcrumbs. Whether that alone is the cause... Testing that commit does indicate it is the introduction of the error in the test (as opposed to a later issue with the sched/wait.c). Still more likely a bug in wait_var than that patch (afaict, since it is a very simple replacement). *** Bug 106184 has been marked as a duplicate of this bug. *** commit 77cbe925bf77bd3159f49c4db0ea89a2045d9071 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Tue Apr 17 18:06:38 2018 +0100 drm/i915/selftests: Fix error checking for wait_var_timeout The old wait_on_atomic_t used a custom callback to perform the schedule(), which used my return semantics of reporting an error code on timeout. wait_var_event_timeout() uses the schedule() return semantics of reporting the remaining jiffies (1 if it timed out with 0 jiffies remaining!) and 0 on failure. This semantic mismatch lead to us falsely claiming a time out occurred. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106085 Fixes: d224985a5e31 ("sched/wait, drivers/drm: Convert wait_on_atomic_t() usage to the new wait_var_event() API") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180417170638.20550-1-chris@chris-wilson.co.uk Thanks!, It seems to be doing the trick! Closing :) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.