Bug 106131

Summary: meson/ninja build missing file gtest.h
Product: Mesa Reporter: charlie <bug0xa3d2>
Component: OtherAssignee: Dylan Baker <baker.dylan.c>
Status: RESOLVED FIXED QA Contact: mesa-dev
Severity: normal    
Priority: medium    
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: attachment-17264-0.html

Description charlie 2018-04-19 00:24:53 UTC
Building with a recent git of mesa the meson/ninja can't find file gtest.h:

[1270/1278] Compiling C++ object 'src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o'.
FAILED: src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o 
ccache c++  -Isrc/mesa/state_tracker/tests/mesa_st_test_common@sta -Isrc/mesa/state_tracker/tests -I../src/mesa/state_tracker/tests -Isrc/gallium/auxiliary -I../src/gallium/auxiliary -I../src/gallium/include -Isrc/mesa -I../src/mesa -Isrc/mapi -I../src/mapi -Isrc -I../src -Isrc/../include -I../src/../include -Isrc/compiler -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++11 -O3 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS '-DVERSION="18.1.0-devel"' -DPACKAGE_VERSION=VERSION '-DPACKAGE_BUGREPORT="https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa"' -DTEXTURE_FLOAT_ENABLED -DGLX_USE_TLS -DHAVE_ST_VDPAU -DENABLE_ST_OMX_BELLAGIO=0 -DENABLE_ST_OMX_TIZONIA=0 -DHAVE_X11_PLATFORM -DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DGLX_USE_DRM -DHAVE_DRM_PLATFORM -DENABLE_SHADER_CACHE -DHAVE___BUILTIN_BSWAP32 -DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS -DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT -DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_UNREACHABLE -DHAVE_FUNC_ATTRIBUTE_CONST -DHAVE_FUNC_ATTRIBUTE_FLATTEN -DHAVE_FUNC_ATTRIBUTE_MALLOC -DHAVE_FUNC_ATTRIBUTE_PURE -DHAVE_FUNC_ATTRIBUTE_UNUSED -DHAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT -DHAVE_FUNC_ATTRIBUTE_WEAK -DHAVE_FUNC_ATTRIBUTE_FORMAT -DHAVE_FUNC_ATTRIBUTE_PACKED -DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL -DHAVE_FUNC_ATTRIBUTE_VISIBILITY -DHAVE_FUNC_ATTRIBUTE_ALIAS -DHAVE_FUNC_ATTRIBUTE_NORETURN -D_GNU_SOURCE -DUSE_SSE41 -DUSE_GCC_ATOMIC_BUILTINS -DUSE_X86_64_ASM -DMAJOR_IN_SYSMACROS -DHAVE_SYS_SYSCTL_H -DHAVE_LINUX_FUTEX_H -DHAVE_ENDIAN_H -DHAVE_STRTOF -DHAVE_MKOSTEMP -DHAVE_POSIX_MEMALIGN -DHAVE_TIMESPEC_GET -DHAVE_MEMFD_CREATE -DHAVE_STRTOD_L -DHAVE_DLADDR -DHAVE_DL_ITERATE_PHDR -DHAVE_ZLIB -DHAVE_PTHREAD -DHAVE_LIBDRM -DHAVE_LLVM=0x0700 -DMESA_LLVM_VERSION_PATCH=0 -DHAVE_WAYLAND_PLATFORM -DWL_HIDE_DEPRECATED -DHAVE_DRI3 -DHAVE_DRI3_MODIFIERS -DHAVE_LIBSENSORS=1 -Wall -fno-math-errno -fno-trapping-math -Wno-non-virtual-dtor -O2 -march=native -fPIC -fvisibility-inlines-hidden -fPIC -pthread -MD -MQ 'src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o' -MF 'src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o.d' -o 'src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o' -c ../src/mesa/state_tracker/tests/st_tests_common.cpp
In file included from ../src/mesa/state_tracker/tests/st_tests_common.cpp:24:0:
../src/mesa/state_tracker/tests/st_tests_common.h:28:10: fatal error: gtest/gtest.h: No such file or directory
 #include <gtest/gtest.h>
          ^~~~~~~~~~~~~~~
compilation terminated.

________

Side question: Is the patch "1-2-bin-install_megadrivers-fix-DESTDIR-and--D--path.patch" from https://bugs.freedesktop.org/show_bug.cgi?id=105567 going to be pushed to mesa git one day?
Comment 1 Dylan Baker 2018-04-19 02:41:05 UTC
Created attachment 138918 [details]
attachment-17264-0.html

I actually ran into this today, I have a patch I'll probably out of a
larger series.

Side quest: please send me a tester by on the other patch and I'll push it,
I just can't get anyone to review it.

I'm on mobile, please excuse autocorrect fail.

On Wed, Apr 18, 2018, 17:24 <bugzilla-daemon@freedesktop.org> wrote:

> Bug ID 106131 <https://bugs.freedesktop.org/show_bug.cgi?id=106131>
> Summary meson/ninja build missing file gtest.h
> Product Mesa
> Version git
> Hardware x86-64 (AMD64)
> OS Linux (All)
> Status NEW
> Severity normal
> Priority medium
> Component Other
> Assignee baker.dylan.c@gmail.com
> Reporter bug0xa3d2@hushmail.com
> QA Contact mesa-dev@lists.freedesktop.org
>
> Building with a recent git of mesa the meson/ninja can't find file gtest.h:
>
> [1270/1278] Compiling C++ object
> 'src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o'.
> FAILED:
> src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o
> ccache c++  -Isrc/mesa/state_tracker/tests/mesa_st_test_common@sta
> -Isrc/mesa/state_tracker/tests -I../src/mesa/state_tracker/tests
> -Isrc/gallium/auxiliary -I../src/gallium/auxiliary -I../src/gallium/include
> -Isrc/mesa -I../src/mesa -Isrc/mapi -I../src/mapi -Isrc -I../src
> -Isrc/../include -I../src/../include -Isrc/compiler -fdiagnostics-color=always
> -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++11
> -O3 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
> '-DVERSION="18.1.0-devel"' -DPACKAGE_VERSION=VERSION
> '-DPACKAGE_BUGREPORT="https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa"'
> -DTEXTURE_FLOAT_ENABLED -DGLX_USE_TLS -DHAVE_ST_VDPAU
> -DENABLE_ST_OMX_BELLAGIO=0 -DENABLE_ST_OMX_TIZONIA=0 -DHAVE_X11_PLATFORM
> -DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DGLX_USE_DRM
> -DHAVE_DRM_PLATFORM -DENABLE_SHADER_CACHE -DHAVE___BUILTIN_BSWAP32
> -DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL
> -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS
> -DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT -DHAVE___BUILTIN_POPCOUNTLL
> -DHAVE___BUILTIN_UNREACHABLE -DHAVE_FUNC_ATTRIBUTE_CONST
> -DHAVE_FUNC_ATTRIBUTE_FLATTEN -DHAVE_FUNC_ATTRIBUTE_MALLOC
> -DHAVE_FUNC_ATTRIBUTE_PURE -DHAVE_FUNC_ATTRIBUTE_UNUSED
> -DHAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT -DHAVE_FUNC_ATTRIBUTE_WEAK
> -DHAVE_FUNC_ATTRIBUTE_FORMAT -DHAVE_FUNC_ATTRIBUTE_PACKED
> -DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL -DHAVE_FUNC_ATTRIBUTE_VISIBILITY
> -DHAVE_FUNC_ATTRIBUTE_ALIAS -DHAVE_FUNC_ATTRIBUTE_NORETURN -D_GNU_SOURCE
> -DUSE_SSE41 -DUSE_GCC_ATOMIC_BUILTINS -DUSE_X86_64_ASM -DMAJOR_IN_SYSMACROS
> -DHAVE_SYS_SYSCTL_H -DHAVE_LINUX_FUTEX_H -DHAVE_ENDIAN_H -DHAVE_STRTOF
> -DHAVE_MKOSTEMP -DHAVE_POSIX_MEMALIGN -DHAVE_TIMESPEC_GET -DHAVE_MEMFD_CREATE
> -DHAVE_STRTOD_L -DHAVE_DLADDR -DHAVE_DL_ITERATE_PHDR -DHAVE_ZLIB -DHAVE_PTHREAD
> -DHAVE_LIBDRM -DHAVE_LLVM=0x0700 -DMESA_LLVM_VERSION_PATCH=0
> -DHAVE_WAYLAND_PLATFORM -DWL_HIDE_DEPRECATED -DHAVE_DRI3 -DHAVE_DRI3_MODIFIERS
> -DHAVE_LIBSENSORS=1 -Wall -fno-math-errno -fno-trapping-math
> -Wno-non-virtual-dtor -O2 -march=native -fPIC -fvisibility-inlines-hidden -fPIC
> -pthread -MD -MQ
> 'src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o'
> -MF
> 'src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o.d'
> -o 'src/mesa/state_tracker/tests/mesa_st_test_common@sta/st_tests_common.cpp.o'
> -c ../src/mesa/state_tracker/tests/st_tests_common.cpp
> In file included from ../src/mesa/state_tracker/tests/st_tests_common.cpp:24:0:
> ../src/mesa/state_tracker/tests/st_tests_common.h:28:10: fatal error:
> gtest/gtest.h: No such file or directory
>  #include <gtest/gtest.h>
>           ^~~~~~~~~~~~~~~
> compilation terminated.
>
> ________
>
> Side question: Is the patch
> "1-2-bin-install_megadrivers-fix-DESTDIR-and--D--path.patch" fromhttps://bugs.freedesktop.org/show_bug.cgi?id=105567 going to be pushed to mesa
> git one day?
>
> ------------------------------
> You are receiving this mail because:
>
>    - You are the assignee for the bug.
>
>
Comment 2 Dylan Baker 2018-04-19 16:13:45 UTC
dffdef67370..051fddb4a9e  master -> master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.