Bug 106249

(In reply to Bastien Nocera from comment #0)
> I was looking at why geoclue was started 3 times in the space of 30 seconds
> in bug 106236.
> 
> >         &inactivity_timeout,
> >         N_("Exit after T seconds of inactivity. Default: 0 (never)"),
> 
> > ExecStart=@libexecdir@/geoclue -t 5
> 
> Would be nice to change this so the default option in the binary is the one
> actually used.

This is on purpose. The usecase of launching the binary is different than service autolaunch. If you launch the binary manually, you don't want it to timeout on you and close it yourself. When it get's launched automatically, on demand, you want the service to go away after some time of no-one using it.

Maybe we want a bigger timeout but we definetely want the timeout for the service.

(In reply to Zeeshan Ali from comment #1)
> (In reply to Bastien Nocera from comment #0)
> > I was looking at why geoclue was started 3 times in the space of 30 seconds
> > in bug 106236.
> > 
> > >         &inactivity_timeout,
> > >         N_("Exit after T seconds of inactivity. Default: 0 (never)"),
> > 
> > > ExecStart=@libexecdir@/geoclue -t 5
> > 
> > Would be nice to change this so the default option in the binary is the one
> > actually used.
> 
> This is on purpose. The usecase of launching the binary is different than
> service autolaunch. If you launch the binary manually, you don't want it to
> timeout on you and close it yourself. When it get's launched automatically,
> on demand, you want the service to go away after some time of no-one using
> it.
> 
> Maybe we want a bigger timeout but we definetely want the timeout for the
> service.

I would expect the "default: 0" in the help to match how geoclue is actually launched. The user that launches geoclue by hand probably wants it to behave like the daemon, not in a different way that wouldn't match the behaviour.

Created attachment 139261 [details] [review]
Move default timeout to main binary

Rather than have the default 5 seconds timeout in 2 separate locations,
move the default timeout value to the binary, so as to reduce the
difference between the interactive and non-interactive behaviour, and
reduce confusion.

Comment on attachment 139261 [details] [review]
Move default timeout to main binary

Review of attachment 139261 [details] [review]:
-----------------------------------------------------------------

ack

Attachment 139261 [details] pushed as 72d8008 - Move default timeout to main binary