Bug 106304

Summary: glcpp/tests/glcpp-test-cr-lf and glcpp/tests/glcpp-test fail
Product: Mesa Reporter: ben <ben>
Component: glsl-compilerAssignee: Dylan Baker <baker.dylan.c>
Status: RESOLVED INVALID QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Test log

Description ben@besd.de 2018-04-28 21:36:28 UTC
Created attachment 139209 [details]
Test log

Hi,
just encountered this when running 'make check'

FAIL: glsl/glcpp/tests/glcpp-test.sh
FAIL: glsl/glcpp/tests/glcpp-test-cr-lf.sh
PASS: glsl/tests/blob-test
PASS: glsl/tests/cache-test
PASS: glsl/tests/general-ir-test
PASS: glsl/tests/optimization-test.sh
PASS: glsl/tests/sampler-types-test
PASS: glsl/tests/uniform-initializer-test
PASS: glsl/tests/warnings-test.sh
PASS: nir/tests/control_flow_tests

if I bypass the failing tests (#) everything else passes
Comment 1 Dylan Baker 2018-04-30 16:50:31 UTC
I can't reproduce this, as of 1c5f4f4e17f74d823d9e38c678e40e9f49e2c053, both "make check", and "ninja test" pass both of these (I'm running autotools out of tree).

Can you give me some more information about your system?
Comment 2 ben@besd.de 2018-04-30 17:09:42 UTC
I think my error messages are different then what is expected

$cpp 132-eof-without-newline-define.c
mine:
# 1 "132-eof-without-newline-define.c"
# 1 "<built-in>"
# 1 "<command-line>"
# 31 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 32 "<command-line>" 2
# 1 "132-eof-without-newline-define.c"
132-eof-without-newline-define.c:1:9: error: no macro name given in #define directive
 #define
         ^
expected:
0:1(1): preprocessor error: #define without macro name

mine:
# 1 "133-eof-without-newline-comment.c"
# 1 "<built-in>"
# 1 "<command-line>"
# 31 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 32 "<command-line>" 2
# 1 "133-eof-without-newline-comment.c"
133-eof-without-newline-comment.c:1:49: error: unterminated comment
 This file ends with no newline within a comment /*
                                                 ^
This file ends with no newline within a comment

expected:
# 1 "133-eof-without-newline-comment.c.expected"
# 1 "<built-in>"
# 1 "<command-line>"
# 31 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 32 "<command-line>" 2
# 1 "133-eof-without-newline-comment.c.expected"
0:1(51): preprocessor error: Unterminated comment
This file ends with no newline within a comment



cpp (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


What other information would you be interested in?
Comment 3 Kenneth Graunke 2018-04-30 18:49:51 UTC
My guess is this has something to do with your LANG and LC_ALL settings...
Comment 4 ben@besd.de 2018-04-30 18:51:54 UTC
LC_ALL isn't set
LANG=de_DE.UTF-8
Comment 5 ben@besd.de 2018-04-30 18:55:32 UTC
FWIW: I can set LC_ALL=C and it still fails
Comment 6 ben@besd.de 2018-04-30 19:12:09 UTC
I just did a fresh clone from git and there it passes just fine.
Dont really see a difference but must be something on my end.

Very sorry, thanks for the effort.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.