| Summary: | False positives with wobble detection | ||
|---|---|---|---|
| Product: | Wayland | Reporter: | Peter Hutterer <peter.hutterer> |
| Component: | libinput | Assignee: | Wayland bug list <wayland-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | Hi-Angel, nate, peter.hutterer |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
evemu with master (doesn't trigger hysteresis)
revert-9c3a597aa (in case anybody need it, as git-revert gets conflicts) |
||
Created attachment 139294 [details]
evemu with master (doesn't trigger hysteresis)
I did the evemu-record by commenting out the "fuzz-enabling-line", then trying to select a text. Hysteresis haven't been enabled.
I think however, the solution to this have already been indirectly mentioned by Peter on ML — it's to revert the 9c3a597aa "reset the wobble detection for non-pointer events", then to use the last movement time, as opposed to any event.
Created attachment 139296 [details] [review] revert-9c3a597aa (in case anybody need it, as git-revert gets conflicts) embarassing... issue is that I had the logic inverted (from an earlier version). This one makes it work:
diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 6560ac3e..ce694c28 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touchpad.c
@@ -155,8 +155,8 @@ tp_detect_wobbling(struct tp_dispatch *tp,
int dx, dy;
uint64_t dtime;
- if (tp->nfingers_down == 1 &&
- tp->nfingers_down == tp->old_nfingers_down)
+ if (tp->nfingers_down != 1 ||
+ tp->nfingers_down != tp->old_nfingers_down)
return;
if (tp->hysteresis.enabled)
(In reply to Peter Hutterer from comment #3) > embarassing... issue is that I had the logic inverted (from an earlier > version). This one makes it work: > > > diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c > index 6560ac3e..ce694c28 100644 > --- a/src/evdev-mt-touchpad.c > +++ b/src/evdev-mt-touchpad.c > @@ -155,8 +155,8 @@ tp_detect_wobbling(struct tp_dispatch *tp, > int dx, dy; > uint64_t dtime; > > - if (tp->nfingers_down == 1 && > - tp->nfingers_down == tp->old_nfingers_down) > + if (tp->nfingers_down != 1 || > + tp->nfingers_down != tp->old_nfingers_down) > return; > > if (tp->hysteresis.enabled) Don't be sad! Thank you, works for me. commit 3d81f1179f007dd555ccf0f183a02494ce22d3a8
Author: Peter Hutterer <>
Date: Thu May 3 19:14:14 2018 +1000
touchpad: only try to detect touchpad wobbling with one finger down
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
New bug for the wobble detection, hoping to short-cut Nate and Konstantin. Since I don't have a wobbly touchpad anywhere near me, it's a bit frustrating to try something only to have the other side tell me it doesn't work. So now you both are in the same arena and can fight it out :) So, current status is: 795657a0 (i.e. the original implementation) has false positives. 30a398591ba2 (git master of today) has false negatives. We need to find a middle ground. Konstantin: reminder that git master auto-enables hysteresis when a fuzz is set, so you always need to comment out this line in tp_init_hysteresis(): tp->hysteresis.enabled = (ax->fuzz || ay->fuzz); K mentioned in a private email that 9c3a597aa "touchpad: reset the wobble detection for non-pointer events" is the culprit, please attach an evemu recording of a wobbly sequence that didn't trigger this.