Bug 106479

Summary:	NDEBUG not defined for libamdgpu_addrlib
Product:	Mesa	Reporter:	Valentin David <valentin.david>
Component:	Drivers/Vulkan/radeon	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch

Description Valentin David 2018-05-11 18:41:38 UTC

Created attachment 139503 [details] [review]
Patch

I got crashes with Vulkan applications using Unity and SteamVR. Among them the SteamVR room setup.

Here is the assertion that breaks.

../../../src/amd/addrlib/core/addrlib2.h:732: VOID Addr::V2::Lib::VerifyMipLevelInfo(const ADDR2_COMPUTE_SURFACE_INFO_INPUT*) const: Assertion `actualMipLevels >= pIn->numMipLevels' failed.

And this breaks even when disabling debug. I suppose the was an oversight when writing the Makefile.

The provided patch solves my issue.

Comment 1 Bas Nieuwenhuizen 2018-05-21 14:51:44 UTC

The NDEBUG issue has been fixed in the latest git.

Could you give more information on how to reproduce the assert so that we also have a chance to fix it?

Alternatively a full backtrace with debug symbols would also be very much appreciated.

Comment 2 Juan A. Suarez 2018-06-03 10:18:41 UTC

Also, please verify with the latest versions.

Comment 3 Samuel Pitoiset 2018-06-13 19:04:48 UTC

This has been fixed by Bas.
https://cgit.freedesktop.org/mesa/mesa/commit/?id=62e0e089d710835d9f79138377bcc37147f75ebd

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.