Summary: | [CI][IGT] DRM-Tip 4.17-rc5 pull made igt@gem_eio@ tests unstable | ||
---|---|---|---|
Product: | DRI | Reporter: | Tomi Sarvela <tomi.p.sarvela> |
Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
Severity: | major | ||
Priority: | high | CC: | intel-gfx-bugs |
Version: | unspecified | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | ALL | i915 features: |
Description
Tomi Sarvela
2018-05-15 07:00:17 UTC
commit 3f6e9822308127104a7bb007ca569f2c57d03b67 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Wed May 16 19:33:55 2018 +0100 drm/i915: Stop parking the signaler around reset We cannot call kthread_park() from softirq context, so let's avoid it entirely during the reset. We wanted to suspend the signaler so that it would not mark a request as complete at the same time as we marked it as being in error. Instead of parking the signaling, stop the engine from advancing so that the GPU doesn't emit the breadcrumb for our chosen "guilty" request. v2: Refactor setting STOP_RING so that we don't have the same code thrice Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Michałt Winiarski <michal.winiarski@intel.com> CC: Michel Thierry <michel.thierry@intel.com> Cc: Jeff McGee <jeff.mcgee@intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180516183355.10553-8-chris@chris-wilson.co.uk (In reply to Chris Wilson from comment #1) > commit 3f6e9822308127104a7bb007ca569f2c57d03b67 > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Wed May 16 19:33:55 2018 +0100 > > drm/i915: Stop parking the signaler around reset > > We cannot call kthread_park() from softirq context, so let's avoid it > entirely during the reset. We wanted to suspend the signaler so that it > would not mark a request as complete at the same time as we marked it as > being in error. Instead of parking the signaling, stop the engine from > advancing so that the GPU doesn't emit the breadcrumb for our chosen > "guilty" request. > > v2: Refactor setting STOP_RING so that we don't have the same code thrice > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > Cc: Michałt Winiarski <michal.winiarski@intel.com> > CC: Michel Thierry <michel.thierry@intel.com> > Cc: Jeff McGee <jeff.mcgee@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Link: > https://patchwork.freedesktop.org/patch/msgid/20180516183355.10553-8- > chris@chris-wilson.co.uk That fixed it, thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.