Bug 106748

Summary: st/mesa: use PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY broke qemu -display sdl,gl=on
Product: Mesa Reporter: Andrew Randrianasulu <randrik>
Component: EGLAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact: mesa-dev
Severity: normal    
Priority: medium CC: maraeo
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: good glxinfo

Description Andrew Randrianasulu 2018-05-31 00:45:48 UTC 
Created attachment 139874 [details]
good glxinfo

Recent mesa commit (" commit dd93bc4f34e83516a08f3aa82f6171667080de67
Author: Marek OlЕЎГЎk <marek.olsak@amd.com>
Date:   Wed May 23 00:46:02 2018 -0400

    st/mesa: use PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY

    Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>" ) broke qemu 2.12 startup on my system with nouveau (nv50 subtype) driver.

It seems GL_ARB_ES3_compatibility in compat profile was somewhat critical, without it qemu complains:

qemu-system-x86_64 -cdrom neon-useredition-20180517-1021-amd64.iso -display sdl,gl=on -m 1G -cpu host -smp 2 -usb -soundhw es1370 -vga virtio -usbdevice mouse -enable-kvm
qemu-system-x86_64: -usbdevice mouse: '-usbdevice' is deprecated, please use '-device usb-...' instead
qemu_gl_create_compile_shader: compile vertex error
0:2(10): error: GLSL ES 3.00 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.40, and 1.00 ES

qemu_gl_create_compile_shader: compile fragment error
0:2(10): error: GLSL ES 3.00 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.40, and 1.00 ES

qemu_gl_create_compile_shader: compile vertex error
0:2(10): error: GLSL ES 3.00 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.40, and 1.00 ES

qemu_gl_create_compile_shader: compile fragment error
0:2(10): error: GLSL ES 3.00 is not supported. Supported versions are: 1.10, 1.20, 1.30, 1.40, and 1.00 ES

git bisect log

# good: [a7d0c53ab89ca86b705014925214101f5bc4187f] st/mesa: fix assertion failures with GL_UNSIGNED_INT64_ARB (v2)
git bisect good a7d0c53ab89ca86b705014925214101f5bc4187f
# bad: [d511bba2f92566c512c86c5f51bd756834cbd444] v3d: Fix automake linking error.
git bisect bad d511bba2f92566c512c86c5f51bd756834cbd444
# bad: [04fff21c62f487f5f24f02708d2a16844688ec81] nv30: add a couple of missed shader caps
git bisect bad 04fff21c62f487f5f24f02708d2a16844688ec81
# bad: [dd93bc4f34e83516a08f3aa82f6171667080de67] st/mesa: use PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY
git bisect bad dd93bc4f34e83516a08f3aa82f6171667080de67
# good: [27a9f273109d0f7826013afcc3b9a3dcd6a79a91] mesa: print Compatibility Profile in the version string
git bisect good 27a9f273109d0f7826013afcc3b9a3dcd6a79a91
# good: [34ea55d8201b9bfd31dd432f45b5423861f8ad0b] gallium: add PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY
git bisect good 34ea55d8201b9bfd31dd432f45b5423861f8ad0b
# first bad commit: [dd93bc4f34e83516a08f3aa82f6171667080de67] st/mesa: use PIPE_CAP_GLSL_FEATURE_LEVEL_COMPATIBILITY
Comment 1 Ilia Mirkin 2018-05-31 00:53:28 UTC 
That patch had nothing to do with ARB_ES3_compatibility -- if that got nuked, it probably did as well for radeonsi. Probably something silly in the version check logic.
Comment 2 Michel Dänzer 2018-05-31 07:56:27 UTC 
(In reply to Ilia Mirkin from comment #1)
> That patch had nothing to do with ARB_ES3_compatibility -- if that got
> nuked, it probably did as well for radeonsi.

Indeed, it did; the piglit ARB_ES3_compatibility tests no longer run either as a consequence.
Comment 3 Marek Olšák 2018-06-01 05:04:55 UTC 
Fixed by:

commit 9e61147ef6de379700b2fec3c9cea30cc2eb23d9 (origin/master, origin/HEAD)
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Thu May 31 15:20:48 2018 -0400

    st/mesa: relax requirements for ARB_ES3_compatibility
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106748
    
    Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.