Bug 106941

Summary:	Intel ANV vulkan driver exposing version 1.1.0 which is incorrect
Product:	Mesa	Reporter:	mercuriete <mercuriete>
Component:	Drivers/Vulkan/intel	Assignee:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Status:	RESOLVED FIXED	QA Contact:	Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity:	minor
Priority:	low	CC:	jason
Version:	18.0
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	vulkan info vulkan info patched

Description mercuriete 2018-06-17 12:10:13 UTC

Hi all

My intel haswell graphics is reporting vulkan version 1.1.0 which doesn't exists.

I think the correct version should be or 1.1.70 or 1.0.69 or something like that.

my gpu is:
https://vulkan.gpuinfo.org/displayreport.php?id=3470

Im am using:
* gentoo linux
* mesa 18.1.2
* vulkan-loader 1.1.70.0

uname -a
Linux localhost.localdomain 4.14.49-gentoo #1 SMP PREEMPT Tue Jun 12 21:09:43 CEST 2018 x86_64 Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz GenuineIntel GNU/Linux

Thanks for your work.

Comment 1 mercuriete 2018-06-17 12:11:05 UTC

Created attachment 140185 [details]
vulkan info

Comment 2 Jason Ekstrand 2018-06-17 23:31:29 UTC

I've been meaning to fix things so that they use a single patch version for all major.minor versions.  The code we have now was written before the decision to use one patch version was made and I never got around fixing it.  Thanks for providing me with an excuse to do so. :-)  I sent a patch to the mailing list which fixes the issue:

https://patchwork.freedesktop.org/patch/229978/

Comment 3 mercuriete 2018-06-18 16:31:37 UTC

ohh nice! :-)

The patch from comment 2 has been:

Tested-by: Abel Garcia Dorta <mercuriete@gmail.com>


I applied the patch on top of maser a3d93eec7cbd3fb733c1ef3b16903265e8e61b23

https://gitlab.freedesktop.org/mesa/mesa/commit/a3d93eec7cbd3fb733c1ef3b16903265e8e61b23


I tested smoketest and it work fine.

I will put the output of vulkaninfo in the next post.

Comment 4 mercuriete 2018-06-18 16:32:05 UTC

Created attachment 140206 [details]
vulkan info patched

Comment 5 mercuriete 2018-06-18 16:57:16 UTC

A little bit of topic:

every time I use a vulkan application I have this warning:

INTEL-MESA: warning: Haswell Vulkan support is incomplete



I tested this patch with dota 2 and It works perfect (around 30fps minimum settings).


I dont believe haswell is incomplete. I think works perfect. maybe someone left that warning and never got deleted?

Comment 6 Lionel Landwerlin 2018-06-18 17:07:27 UTC

As far as I remember, Haswell cannot pass all of Vulkan 1.0 conformance tests.

Comment 7 mercuriete 2018-06-18 19:01:41 UTC

oh ok!

but I have an amd integrated graphic card and the message is less missleading:



INTEL-MESA: warning: Haswell Vulkan support is incomplete
WARNING: radv is not a conformant vulkan implementation, testing use only.


anyways, thanks for fix the issue :-)

Comment 8 Jason Ekstrand 2018-06-19 00:13:19 UTC

This is fixed by the following commit now in master:

commit 0146d7963651ca3226a8bf25eb683624ce3b0143 (public/master)
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Sun Jun 17 16:28:02 2018 -0700

    anv: Use a single global API patch version
    
    The Vulkan API has only one patch version shared among all of the
    major.minor versions.  We should also advertise the same patch version
    regardless of major.minor.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106941
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.