| Summary: | [CI] igt@gem_eio@(hibernate|suspend) - incomplete - WARNING execlists_submission_tasklet | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Martin Peres <martin.peres> |
| Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | intel-gfx-bugs |
| Version: | XOrg git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | ReadyForDev | ||
| i915 platform: | BDW, BSW/CHT, BXT, CFL, CNL, GLK, KBL, SKL | i915 features: | GEM/Other |
|
Description
Martin Peres
2018-06-18 14:04:13 UTC
commit 4fdd5b4e9aba5fbbc6d3072a5a87fa1d3f3fc030 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Sat Jun 16 21:25:34 2018 +0100 drm/i915: Fix fallout of fake reset along resume commit b2209e62a450 ("drm/i915/execlists: Reset the CSB head tracking on reset/sanitization") and commit 1288786b18f7 ("drm/i915: Move GEM sanitize from resume_early to resume") show the conflicting requirements on the code. We must reset the GPU before trashing live state on a fast resume (hibernation debug, or error paths), but we must only reset our state tracking iff the GPU is reset (or power cycled). This is tricky if we are disabling GPU reset to simulate broken hardware; we reset our state tracking but the GPU is left intact and recovers from its stale state. v2: Again without the assertion for forcewake, no longer required since commit b3ee09a4de33 ("drm/i915/ringbuffer: Fix context restore upon reset") as the contexts are reset from the CS ensuring everything is powered up. Fixes: b2209e62a450 ("drm/i915/execlists: Reset the CSB head tracking on reset/sanitization") Fixes: 1288786b18f7 ("drm/i915: Move GEM sanitize from resume_early to resume") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180616202534.18767-1-chris@chris-wilson.co.uk Closing, thanks. Still happening with drm-tip: 2018y-06m-17d-12h-42m-13s UTC integration manifest https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_66/fi-whl-u/igt@gem_eio@suspend.html https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_66/fi-whl-u/igt@gem_eio@hibernate.html The output looks a little different though, so I guess it is progress? :) Bug fix hasn't percolated as far as drmtip-66. Check again after drmtip-67/-68! (In reply to Chris Wilson from comment #4) > Bug fix hasn't percolated as far as drmtip-66. Check again after > drmtip-67/-68! Are you sure? You pushed the patch on the 16th, and the drmtip run was with drmtip 2018y-06m-17d-12h-42m-13s. Pretty confident, yes. The error (CSB head==5 but mmio reads 1) is the same as fixed by the patch, and the same as showing up in the shards for https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4332/ fixed in CI_DRM_4333. I do think we need a clearer indication of what base drmtip is using. drm-intel drm-intel-next-queued f677bd558de2e98b70b7f8c522024b26d2d1120d drm/i915/icl: update VBT's child_device_config flags2 field which is just (2 patches!) before commit 4fdd5b4e9aba5fbbc6d3072a5a87fa1d3f3fc030 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Sat Jun 16 21:25:34 2018 +0100 drm/i915: Fix fallout of fake reset along resume was committed. Indeed was not reproduced on drmtip_67. Closing! Thanks and sorry for the noise :s |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.