| Summary: | draglock.c:134:2: warning: 'memset' writing 4112 bytes into a region of size 1028 overflows the destination | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Martin Liska <mliska> | ||||
| Component: | Input/libinput | Assignee: | Peter Hutterer <peter.hutterer> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | normal | ||||||
| Priority: | medium | CC: | peter.hutterer | ||||
| Version: | unspecified | ||||||
| Hardware: | Other | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
Created attachment 140521 [details] [review] patch candidate There's missing division by size of array element. Sent a slightly more extensive patch to the list to avoid future ambiguities there, please see here: https://patchwork.freedesktop.org/patch/237418/ (In reply to Peter Hutterer from comment #2) > Sent a slightly more extensive patch to the list to avoid future ambiguities > there, please see here: > https://patchwork.freedesktop.org/patch/237418/ Thanks for the fix. commit 0909a1a76546284f27fb1b17a6f545a04537cc36
Author: Peter Hutterer <>
Date: Tue Jul 10 11:17:50 2018 +1000
draglock: fix memory overwrite during draglock parsing
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Building with LTO I see following warning: In function 'draglock_get_pairs.constprop', inlined from 'LibinputInitDragLockProperty' at xf86libinput.c:5328:8: draglock.c:134:2: warning: 'memset' writing 4112 bytes into a region of size 1028 overflows the destination [-Wstringop-overflow=] memset(array, 0, sz * sizeof(array[0])); ^