Bug 107357

Summary: [CI][BAT] igt@pm_rpm@basic - fail - Failed assertion: wait_for_suspended()
Product: DRI Reporter: Martin Peres <martin.peres>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: high CC: intel-gfx-bugs
Version: XOrg git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: BYT i915 features: power/runtime PM

Description Martin Peres 2018-07-24 08:23:41 UTC 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4529/fi-byt-clapper/igt@pm_rpm@basic-pci-d3-state.html

(pm_rpm:3780) CRITICAL: Test assertion failure function pci_d3_state_subtest, file ../tests/pm_rpm.c:1360:
(pm_rpm:3780) CRITICAL: Failed assertion: wait_for_suspended()
Subtest basic-pci-d3-state failed.


https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4529/fi-byt-clapper/igt@pm_rpm@basic-rte.html

(pm_rpm:3783) CRITICAL: Test assertion failure function basic_subtest, file ../tests/pm_rpm.c:733:
(pm_rpm:3783) CRITICAL: Failed assertion: wait_for_suspended()
Subtest basic-rte failed.
Comment 1 Chris Wilson 2018-08-10 15:15:43 UTC 
commit 46e831abe864a6b59fa3de253a681c0f2ee1bf2f
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Aug 2 15:04:16 2018 +0100

    drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"
    
    The LPE audio is a child device of i915, it is powered up and down
    alongside the igfx and presents no independent runtime interface. This
    aptly fulfils the description of a "No-Callback" Device, so mark it
    thus.
    
    Fixes: 183c00350ccd ("drm/i915: Fix runtime PM for LPE audio")
    Testcase: igt/pm_rpm/basic-pci-d3-state
    Testcase: igt/pm_rpm/basic-rte
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Takashi Iwai <tiwai@suse.de>
    Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Cc: stable@vger.kernel.org
    Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20180802140416.6062-1-chris@chris-wilson.co.uk
Comment 2 Martin Peres 2018-09-07 15:50:28 UTC 
(In reply to Chris Wilson from comment #1)
> commit 46e831abe864a6b59fa3de253a681c0f2ee1bf2f
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Thu Aug 2 15:04:16 2018 +0100
> 
>     drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"
>     
>     The LPE audio is a child device of i915, it is powered up and down
>     alongside the igfx and presents no independent runtime interface. This
>     aptly fulfils the description of a "No-Callback" Device, so mark it
>     thus.
>     
>     Fixes: 183c00350ccd ("drm/i915: Fix runtime PM for LPE audio")
>     Testcase: igt/pm_rpm/basic-pci-d3-state
>     Testcase: igt/pm_rpm/basic-rte
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>     Cc: Takashi Iwai <tiwai@suse.de>
>     Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>     Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>     Cc: stable@vger.kernel.org
>     Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>     Link:
> https://patchwork.freedesktop.org/patch/msgid/20180802140416.6062-1-
> chris@chris-wilson.co.uk

Thanks, this definitely fixed the issue :)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.