Bug 107485

Summary: TearFree no longer functional
Product: xorg Reporter: Greg White <gwhite>
Component: Driver/AMDgpuAssignee: xf86-video-ati maintainers <xorg-driver-ati>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
xorg.0.log
none
xrandr --prop none

Description Greg White 2018-08-04 14:40:54 UTC
With the latest git, I am now seeing a great deal of tearing.

Possibly useful: my monitor is rotated.

The card is an Rx550.
Comment 1 Michel Dänzer 2018-08-06 09:13:43 UTC
Please attach the corresponding Xorg log file and the output of xrandr --prop.

Which Git commit are you using exactly?
Comment 2 Greg White 2018-08-06 09:51:18 UTC
Created attachment 140972 [details]
xorg.0.log
Comment 3 Greg White 2018-08-06 09:51:44 UTC
Created attachment 140973 [details]
xrandr --prop
Comment 4 Greg White 2018-08-06 09:52:21 UTC
Git is at 08c4d42f43f80baa4bbc2ff9d0a422202cdc3538 (head as of now.)  Logs/props attached.
Comment 5 Michel Dänzer 2018-08-16 14:38:20 UTC
Does https://patchwork.freedesktop.org/patch/244860/ fix it?

If not, can you bisect which commit introduced the problem?
Comment 6 Greg White 2018-08-16 16:48:14 UTC
I just rebuilt from git (with HEAD at 	f6cd72e64e85896b6d155bee0930e59771dcb701 / Use correct FB handle in amdgpu_do_pageflip) and TearFree seems to be working.  I also only see this in Xorg.0.log:

[  2843.868] (WW) AMDGPU(0): get vblank counter failed: Invalid argument
[  2843.910] (WW) AMDGPU(0): get vblank counter failed: Invalid argument
[  2844.064] (WW) AMDGPU(0): get vblank counter failed: Invalid argument
[  2844.566] (II) AMDGPU(0): EDID vendor "GSM", prod id 23305
[  2844.566] (II) AMDGPU(0): Using hsync ranges from config file
[  2844.566] (II) AMDGPU(0): Using vrefresh ranges from config file
[  2844.566] (II) AMDGPU(0): Printing DDC gathered Modelines:
[  2844.566] (II) AMDGPU(0): Modeline "3840x2160"x0.0  533.25  3840 3888 3920 4000  2160 2214 2219 2222 +hsync -vsync (133.3 kHz eP)
[  2844.566] (II) AMDGPU(0): Modeline "3840x2160"x0.0  266.64  3840 3848 3992 4000  2160 2214 2219 2222 +hsync -vsync (66.7 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "1920x1080"x0.0  148.50  1920 2008 2052 2200  1080 1084 1089 1125 +hsync +vsync (67.5 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "2560x1440"x0.0  241.50  2560 2608 2640 2720  1440 1443 1448 1481 +hsync -vsync (88.8 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "1280x720"x0.0   74.25  1280 1390 1430 1650  720 725 730 750 +hsync +vsync (45.0 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "720x480"x0.0   27.00  720 736 798 858  480 489 495 525 -hsync -vsync (31.5 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "640x480"x0.0   25.18  640 656 752 800  480 490 492 525 -hsync -vsync (31.5 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "800x600"x0.0   40.00  800 840 968 1056  600 601 605 628 +hsync +vsync (37.9 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "1024x768"x0.0   65.00  1024 1048 1184 1344  768 771 777 806 -hsync -vsync (48.4 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "1152x864"x60.0   81.75  1152 1216 1336 1520  864 867 871 897 -hsync +vsync (53.8 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "1280x1024"x0.0  108.00  1280 1328 1440 1688  1024 1025 1028 1066 +hsync +vsync (64.0 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "1600x900"x59.9  118.25  1600 1696 1856 2112  900 903 908 934 -hsync +vsync (56.0 kHz e)
[  2844.566] (II) AMDGPU(0): Modeline "1280x800"x0.0   83.50  1280 1352 1480 1680  800 803 809 831 -hsync +vsync (49.7 kHz e)
[  2847.020] (WW) AMDGPU(0): flip queue failed: Device or resource busy
[  2847.020] (WW) AMDGPU(0): Page flip failed: Device or resource busy
[  2847.020] (EE) AMDGPU(0): present flip failed
Comment 7 Michel Dänzer 2018-08-17 08:10:09 UTC
Thanks for the report, fixed in Git master:

commit f6cd72e64e85896b6d155bee0930e59771dcb701
Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Thu Aug 16 16:31:01 2018 +0200

    Use correct FB handle in amdgpu_do_pageflip

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.