Bug 107496

Summary: Old Hungarian letters and its req. missing
Product: DejaVu Reporter: Kovács Viktor <kovacs.viktor.dev>
Component: GeneralAssignee: Deja Vu bugs <dejavu-bugs>
Status: REOPENED --- QA Contact:
Severity: normal    
Priority: high CC: fitojb, kovacs.viktor.dev, moyogo, rovasinfo, vstuart.foote
Version: unspecified   
Hardware: Other   
OS: All   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=102425
Whiteboard:
i915 platform: i915 features:
Attachments: Old Hungarian letters and its req. patch
Full test for patch
Old Hungarian and its req patch with better readability
Test the OldHungarian_2.patch
This document is the Old Hungarian ext. in tables
Testcase Sans form

Description Kovács Viktor 2018-08-06 13:11:33 UTC

    
Comment 2 Kovács Viktor 2018-08-06 14:05:09 UTC
Created attachment 140981 [details] [review]
Old Hungarian letters and its req. patch

Final for DejavuSans Old Hungarian parts, final req for all Dejavu fonts.
Comment 3 Kovács Viktor 2018-08-06 14:09:25 UTC
@Denis:
I hope, its useable. Please merge it.
Comment 4 Kovács Viktor 2018-08-06 14:13:22 UTC
@Denis: Pull request is: https://github.com/dejavu-fonts/dejavu-fonts/pull/27
Thanks:
Viktor
Comment 5 Kovács Viktor 2018-08-08 07:01:24 UTC
@Denis: Pull request #27 removed, because had mistakes.
I won't to upload anything to github, while you check the patch.
After that I ask you or Adolfo, help me how to upload it.
Comment 6 Kovács Viktor 2018-08-08 07:05:21 UTC
@Adolfo: When Denis checked the patch, I would like ask You or Denis, help me how to upload patch to github.
Comment 7 Kovács Viktor 2018-08-08 07:08:34 UTC
I will upload a testpage, as soon as possible. Now I on a holiday for a week.
Comment 8 Kovács Viktor 2018-08-08 07:12:21 UTC
@Stuart: Please switch the status to "Confirmed", wheter you think, its required.
Comment 9 Kovács Viktor 2018-08-13 20:22:47 UTC
@Denis, my question is: just only the patch file required to upload to github or all changed source files?
Comment 10 Kovács Viktor 2018-08-15 05:56:13 UTC
Created attachment 141098 [details]
Full test for patch

This is the full patch test page in pdf format.
Comment 11 Kovács Viktor 2018-08-16 09:35:36 UTC
@Adolfo: Is it enough to upload the patch to github, or full source files is required?
Comment 12 Kovács Viktor 2018-08-21 11:39:07 UTC
@Denis: Please adopt this patch for Dejavu-fonts!
Comment 13 Kovács Viktor 2018-10-21 08:59:09 UTC
Created attachment 142117 [details] [review]
Old Hungarian  and its req patch with better readability

This changed patch is developed in better readibility.
Old Hungarian part developed for Sans, Sans Bold, Sans Bold Oblique and Sans Oblique. The all Sans and Serif subfonts implements its missing requirements, as reversed comma and reversed double 99 low quote mark.

This patch hardly recomended for bug 
https://bugs.documentfoundation.org/show_bug.cgi?id=103405

Other fixed required bugs for previous bug 
are:
https://bugs.documentfoundation.org/show_bug.cgi?id=107204
https://bugs.documentfoundation.org/show_bug.cgi?id=116157
https://bugs.documentfoundation.org/show_bug.cgi?id=116322
https://bugs.documentfoundation.org/show_bug.cgi?id=97406
https://bugs.documentfoundation.org/show_bug.cgi?id=95162
https://bugs.freedesktop.org/show_bug.cgi?id=102425
Comment 14 Kovács Viktor 2018-10-21 09:03:24 UTC
Created attachment 142118 [details]
Test the OldHungarian_2.patch
Comment 15 Kovács Viktor 2018-10-21 09:07:29 UTC
cc: Stuart, is there any font acceptation method for UNICODE standard?
Comment 16 V Stuart Foote 2018-10-21 14:23:29 UTC
(In reply to Kovács Viktor from comment #15)
> cc: Stuart, is there any font acceptation method for UNICODE standard?

No, they are font foundry neutral. You are free to assign any glyph(s) desired to the established Unicode point/name values U+10C80..U+10CFF. Obviously if you assign the wrong glyph to a point the users will not appreciate it, just keep to the Unicode specification. Styling the glyphs are up to the font designer(s) and whatever internal approval to publish.

For missing codepoints you'd have to use a PUA assignment in the target font to start with--and users, applications would have to pick it up there.

And when additional glyphs are accepted by users, then petition Unicode to add glyphs to the U+10C80..U+10CFF reserved range, U+10cB3-BF and U+10CF3-F9. Or possibly assign an additional block.
Comment 17 Kovács Viktor 2018-10-21 15:21:19 UTC
I don't want extend or override the standard. I would like if someone tell that the font not override or extend the standard.
Comment 18 Kovács Viktor 2018-10-21 19:29:04 UTC
Created attachment 142121 [details]
This document is the Old Hungarian ext. in tables

cc:Denis, You have the law, You are my judge.

Is it acceptable as Old Hungarian extension for DejaVu Sans fonts?

The original standard is:
https://unicode.org/charts/PDF/U10C80.pdf
Comment 19 Kovács Viktor 2018-10-24 01:47:18 UTC
cc:Denis, tell me, the patch is acceptable for DejaVu sans font?
Comment 20 Kovács Viktor 2018-11-04 00:30:17 UTC
cc:Denis, will you fix this bug in the near future?
Comment 21 Tamas Rumi 2019-02-03 16:10:45 UTC
(In reply to Kovács Viktor from comment #17)
> I don't want extend or override the standard. I would like if someone tell
> that the font not override or extend the standard.

If we can not override the Unicode standard the Deja Vu font will not be fully compatible for the users. Using PUE area can be a temp solution.
Comment 22 Tamas Rumi 2019-02-03 16:27:27 UTC
(In reply to V Stuart Foote from comment #16)
> (In reply to Kovács Viktor from comment #15)
> > cc: Stuart, is there any font acceptation method for UNICODE standard?
> 
> No, they are font foundry neutral. You are free to assign any glyph(s)
> desired to the established Unicode point/name values U+10C80..U+10CFF.
> Obviously if you assign the wrong glyph to a point the users will not
> appreciate it, just keep to the Unicode specification.

There are empty slot in the so called Old Hungarian area. We ccould use them instead of PUA area. The reason is that the Unicode standard does not meet with the reality, we definitely need these additional empty code points.
On the other hand there are strongly different glyph variants (for example UEE), because of historical reasons. 

 Styling the glyphs
> are up to the font designer(s) and whatever internal approval to publish.

We have developed rovas fonts, used in 90% of rovas books published in Hungary. We are ready to give it freely for the Dejavu font family and its users. This character set is widely known amongst rovas book readers.
> 
> For missing codepoints you'd have to use a PUA assignment in the target font

According to our experience, the PUA assignment is not eligible, using this area shows the lacking characters from the Unicode standards. 

> to start with--and users, applications would have to pick it up there.
> 
> And when additional glyphs are accepted by users, then petition Unicode to
> add glyphs to the U+10C80..U+10CFF reserved range, U+10cB3-BF and
> U+10CF3-F9. Or possibly assign an additional block.

We have had many proposal in the last ten years, but there are still missing code points.
Comment 23 Kovács Viktor 2019-02-03 17:16:18 UTC
How could I buy these books? ;) I have just only one. :(
If you make a better patch, I step to back.
Comment 24 Kovács Viktor 2019-02-12 17:51:26 UTC
(In reply to Tamas Rumi from comment #22)
> We have had many proposal in the last ten years, but there are still missing
> code points.
Tamás, I don't understand, why would be better, if Old Hungarian UNICODE block would have 128 characters instead of "only" 108? If You with the other "Rovás" communities would agree, it would be possible.
Comment 25 Tamas Rumi 2019-02-21 12:47:29 UTC
> Tamás, I don't understand, why would be better, if Old Hungarian UNICODE
> block would have 128 characters instead of "only" 108? If You with the other
> "Rovás" communities would agree, it would be possible.

You know it very well (see contributions made to Unicode), the current standard simply does not contains all letters of contemporary Hungarian alphabet. 
We are ready to provide these missing characters to Deja Vu font set.
Comment 26 Kovács Viktor 2019-02-28 16:41:46 UTC
Created attachment 143496 [details]
Testcase Sans form

This is the test case of DejaVu Sans basics. (regular,oblique, bold, bold-oblique)
Github doesn't require direct patch file, just only diff.
The Serif version is duplicated from Sans version. 
True Serif version is impossible for this part of Unicode range. (See, for example Old Hungarian letter l)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.