Bug 107768

Summary:	[CI][DRMTIP] igt@kms_vblank@pipe-[abc]-ts-continuation-(modeset\|dpms)-rpm - fail - Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Product:	DRI	Reporter:	Martin Peres <martin.peres>
Component:	DRM/Intel	Assignee:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Status:	CLOSED FIXED	QA Contact:	Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity:	normal
Priority:	high	CC:	intel-gfx-bugs
Version:	XOrg git
Hardware:	Other
OS:	All
Whiteboard:	ReadyForDev
i915 platform:	ICL	i915 features:	power/runtime PM

Description Martin Peres 2018-08-31 10:22:06 UTC

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_96/fi-icl-u/igt@kms_vblank@pipe-a-ts-continuation-modeset-rpm.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_96/fi-icl-u/igt@kms_vblank@pipe-a-ts-continuation-dpms-rpm.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_96/fi-icl-u/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_96/fi-icl-u/igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_96/fi-icl-u/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_96/fi-icl-u/igt@kms_vblank@pipe-c-ts-continuation-dpms-rpm.html

(kms_vblank:1566) CRITICAL: Test assertion failure function vblank_ts_cont, file ../tests/kms_vblank.c:355:
(kms_vblank:1566) CRITICAL: Failed assertion: igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED)
Subtest pipe-C-ts-continuation-modeset-rpm failed.(km

Comment 1 Martin Peres 2018-08-31 10:24:27 UTC

Increasing the priority because it is icelake-specific.

Comment 2 Imre Deak 2018-08-31 11:00:07 UTC

This fails due to runtime PM being disabled because of lack of DMC firmware. The following two patches should add support for loading the firmware:

https://patchwork.freedesktop.org/patch/246723/

https://patchwork.freedesktop.org/patch/246153/

Comment 3 Chris Wilson 2018-08-31 15:21:32 UTC

DMC enabling is en route, for now we can just squelch the expected failure with

commit 9d83154c898b5acc8b462d17104df50cfd71e9a0 (HEAD, upstream/master)
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Aug 31 14:06:10 2018 +0100

    tests/kms_vblank: Test if we have functional rpm before testing
    
    We want to test that provoking a vblank interrupt works correctly after
    waking up from runtime-pm. First though, we must wait for the device to
    enter runtime-suspend. If the device cannot, e.g. we haven't enabled the
    DMC firmware, the test should skip because our external requirements are
    not met.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107768
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Imre Deak <imre.deak@intel.com>
    Reviewed-by: Imre Deak <imre.deak@intel.com>

Comment 4 Martin Peres 2018-09-03 07:54:39 UTC

This patch landed in drmtip_98 and fixed it. Thanks Chris!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.