Bug 108147

This likely got introduced in b20815255693 drm/i915: Add plane alpha blending support, v2.

Cc:ing mlankhorst.

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4917/shard-apl5/igt@kms_color@pipe-c-ctm-max.html

Starting subtest: pipe-C-ctm-max
(kms_color:3696) CRITICAL: Test assertion failure function run_tests_for_pipe, file ../tests/kms_color.c:1000:
(kms_color:3696) CRITICAL: Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm)
Subtest pipe-C-ctm-max failed.

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4963/shard-skl5/igt@kms_color@pipe-a-ctm-max.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4962/shard-skl9/igt@kms_color@pipe-a-ctm-max.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4960/shard-skl1/igt@kms_color@pipe-a-ctm-max.html

Starting subtest: pipe-A-ctm-max
(kms_color:1204) CRITICAL: Test assertion failure function run_tests_for_pipe, file ../tests/kms_color.c:1000:
(kms_color:1204) CRITICAL: Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm)
Subtest pipe-A-ctm-max failed.

Also seen on KBL suddenly: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5028/shard-kbl6/igt@kms_color@pipe-a-ctm-max.html

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5027/shard-kbl4/igt@kms_color@pipe-a-ctm-max.html

https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4689/shard-kbl2/igt@kms_color@pipe-a-ctm-max.html

Starting subtest: pipe-A-ctm-max
(kms_color:1166) CRITICAL: Test assertion failure function run_tests_for_pipe, file ../tests/kms_color.c:1000:
(kms_color:1166) CRITICAL: Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm)
Subtest pipe-A-ctm-max failed.

Also seen on WHL: https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_150/fi-whl-u/igt@kms_color@pipe-a-ctm-max.html

Starting subtest: pipe-A-ctm-max
(kms_color:1623) CRITICAL: Test assertion failure function run_tests_for_pipe, file ../tests/kms_color.c:1000:
(kms_color:1623) CRITICAL: Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm)
Subtest pipe-A-ctm-max failed.

A CI Bug Log filter associated to this bug has been updated:

{- old_filter.description -}
{+ new_filter.description +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_179/fi-bxt-dsi/igt@kms_color@pipe-c-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_179/fi-bxt-j4205/igt@kms_color@pipe-c-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_179/fi-cfl-8109u/igt@kms_color@pipe-c-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_179/fi-cfl-8700k/igt@kms_color@pipe-c-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_179/fi-cfl-guc/igt@kms_color@pipe-c-ctm-max.html

A CI Bug Log filter associated to this bug has been updated:

{- BXT APL SKL KBL CFL WHL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ BXT APL SKL KBL GLK CFL WHL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-glk2/igt@kms_color@pipe-c-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-glk8/igt@kms_color@pipe-b-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-glk1/igt@kms_color@pipe-b-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-glk4/igt@kms_color@pipe-c-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-glk5/igt@kms_color@pipe-a-ctm-max.html

A CI Bug Log filter associated to this bug has been updated:

{- BXT APL SKL KBL GLK CFL WHL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ BXT APL SKL KBL GLK CFL WHL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

New failures caught by the filter:

* https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5598/shard-iclb7/igt@kms_color@pipe-a-ctm-max.html
* https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4824/shard-iclb6/igt@kms_color@pipe-a-ctm-max.html

A CI Bug Log filter associated to this bug has been updated:

{- BXT APL SKL KBL GLK CFL WHL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ BXT APL SKL KBL GLK CFL WHL ICL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

 No new failures caught with the new filter

Assigned to Uma to explain / investigate

A patch series fixing this issue has been posted by Uma: https://patchwork.freedesktop.org/series/58412/

Comments from Uma:
I have been working on it. Today, I was able to root cause this issue and have a fix for this. This needs a fix in IGT tests, uploaded the patch for the same to igt-dev mailing list.

This required 2 fixes, one in kernel and one IGT:

Kernel: https://patchwork.freedesktop.org/series/58734/
Fixed GC MAX register programming for gamma luts

This changes is reviewed and merged to drm-tip

IGT: https://patchwork.freedesktop.org/series/58412/
tests/kms_color: Fix CRC mismatch issues with ctm test

This also is reviewed and acked-by Daniel. Yet to be merged to IGT tree's.

The IGT patch is merged:

commit 64d0ff7247497ae6d726e4535fe74d4bb6ae914a (HEAD -> master, origin/master, origin/HEAD)
Author: Uma Shankar <uma.shankar@intel.com>
Date:   Wed Apr 3 17:50:10 2019 +0530

    tests/kms_color: Fix CRC mismatch issues with ctm test
    
    Due to Gamma/Degamma limitation wrt representation of intermediate
    values between 0 and 1.0 causing rounding issues and inaccuracies,
    applying linear gamma affects crc. This patch fixes the same by
    making ctm max test independent of gamma/degamma.
    
    v2: Disable degamma/gamma programming for ctm max test as it
    leads to crc mimsmatch. Limiting it to this test case alone as
    other tests need it to be enabled, hence not touching those
    scenarios.
    
    v3: Fixed a fumble with compilation.
    
    v4: Disabling degamma and gamma for ctm max tests, after the logic
    in kernel has been updated by Ville's series.
    
    v5: Disabled gamma/degamma for all ctm tests as suggested by Ville.
    
    v6: Restricting disabling of linear gamma luts for ctm max test.
    Updated the commit message and comment as suggested by Daniel.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
    Signed-off-by: Uma Shankar <uma.shankar@intel.com>
    Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Uma, please do the same when the kernel patch lands and then you can close the bug. I'll close it in cibuglog when I can verify this is indeed fixed.

Thanks Martin for merging this patch to IGT tree. The kernel change has already been merged to drm-tip so we should not see this issue now on CI.

Regards,
Uma Shankar

Hey, thanks for the fix Uma. Seems like it helped. Originally the issue was seen on APL, GLK, SKL, ICL every shard run. Currently the issue was not seen in quite a while on anything but glk-dsi on drmtip runs.

Here are some sample logs from failures that a re still ongoing:
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_255/fi-glk-dsi/igt@kms_color@pipe-c-ctm-max.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_254/fi-glk-dsi/igt@kms_color@pipe-c-ctm-max.html
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_253/fi-glk-dsi/igt@kms_color@pipe-c-ctm-max.html

Changing affected platform to GLK.

A CI Bug Log filter associated to this bug has been updated:

{- BXT APL SKL KBL GLK CFL WHL ICL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ GLK: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

 No new failures caught with the new filter

A CI Bug Log filter associated to this bug has been updated:

{- GLK: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ APL GLK: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5029/shard-apl2/igt@kms_color@pipe-c-ctm-max.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6182/shard-apl6/igt@kms_color@pipe-c-ctm-max.html

A CI Bug Log filter associated to this bug has been updated:

{- APL GLK: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ SKL APL KBL GLK: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5045/shard-kbl2/igt@kms_color@pipe-b-ctm-max.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5045/shard-skl5/igt@kms_color@pipe-b-ctm-max.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6211/shard-kbl4/igt@kms_color@pipe-b-ctm-max.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6211/shard-skl6/igt@kms_color@pipe-b-ctm-max.html

Is this bug still reproducible, if not we can close it.

Uma, look from cibuglog and asses yourself.

(In reply to Uma Shankar from comment #20)
> Is this bug still reproducible, if not we can close it.

From the last 5 months, issue used to appear once in 25 CI_DRM runs. Last seen on CI_DRM_6428 and current run is CI_DRM_6874 
One drmtip runs issue used to occur once in 1.4 drmtip runs, last seen on drmtip_273 and current run is drmtip_366. 

Closing this issue as WORKSFORME.

(In reply to Lakshmi from comment #22)
> (In reply to Uma Shankar from comment #20)
> > Is this bug still reproducible, if not we can close it.
> 
> From the last 5 months, issue used to appear once in 25 CI_DRM runs. Last
> seen on CI_DRM_6428 and current run is CI_DRM_6874 
> One drmtip runs issue used to occur once in 1.4 drmtip runs, last seen on
> drmtip_273 and current run is drmtip_366. 
> 
> Closing this issue as WORKSFORME.

Will reopen if it occurs again.

The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.

The CI Bug Log issue associated to this bug has been restored.

All the previous filters are now active.

Reopening this issue as it came back on KBL

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6916/shard-kbl7/igt@kms_color@pipe-a-ctm-max.html
Starting subtest: pipe-A-ctm-max
(kms_color:9260) CRITICAL: Test assertion failure function run_tests_for_pipe, file ../tests/kms_color.c:1045:
(kms_color:9260) CRITICAL: Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm)
Subtest pipe-A-ctm-max failed.

The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* TGL: igt@kms_color@pipe-a-ctm-red-to-blue - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, blue_green_blue, ctm)
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6965/shard-tglb1/igt@kms_color@pipe-a-ctm-red-to-blue.html

(In reply to Lakshmi from comment #26)
> Reopening this issue as it came back on KBL
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6916/shard-kbl7/
> igt@kms_color@pipe-a-ctm-max.html
> Starting subtest: pipe-A-ctm-max
> (kms_color:9260) CRITICAL: Test assertion failure function
> run_tests_for_pipe, file ../tests/kms_color.c:1045:
> (kms_color:9260) CRITICAL: Failed assertion: test_pipe_ctm(data, primary,
> red_green_blue, full_rgb, ctm)
> Subtest pipe-A-ctm-max failed.

@Uma this is on TGL. Please let me know if this needs separate bug.

Gen11+ should be separate issue. Lets track color issues on Gen11+ under 1 bucket (ICL, TGL etc) and pre GEN11 under another category.

(In reply to Uma Shankar from comment #29)
> Gen11+ should be separate issue. Lets track color issues on Gen11+ under 1
> bucket (ICL, TGL etc) and pre GEN11 under another category.

Thanks for the clarification. Separate Bug 111859 is created for TGL failure.

The CI Bug Log issue associated to this bug has been updated.

### Removed filters

* TGL: igt@kms_color@pipe-a-ctm-red-to-blue - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, blue_green_blue, ctm) (added on 3 days, 23 hours ago)

A CI Bug Log filter associated to this bug has been updated:

{- SKL APL KBL GLK: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ APL BXT SKL KBL GLK: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_404/fi-bxt-dsi/igt@kms_color@pipe-c-ctm-max.html

A CI Bug Log filter associated to this bug has been updated:

{- APL BXT SKL KBL GLK: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ APL BXT SKL KBL GLK CFL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_404/fi-cfl-8700k/igt@kms_color@pipe-c-ctm-max.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_404/fi-cfl-guc/igt@kms_color@pipe-c-ctm-max.html

A CI Bug Log filter associated to this bug has been updated:

{- APL BXT SKL KBL GLK CFL: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) -}
{+ APL BXT SKL KBL GLK WHL CFL CML: igt@kms_color@pipe-[abc]-ctm-max - fail - Failed assertion: test_pipe_ctm(data, primary, red_green_blue, full_rgb, ctm) +}

New failures caught by the filter:

  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_404/fi-cml-s/igt@kms_color@pipe-c-ctm-max.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_404/fi-cml-u2/igt@kms_color@pipe-c-ctm-max.html
  * https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_404/fi-whl-u/igt@kms_color@pipe-c-ctm-max.html

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/drm/intel/issues/168.