Bug 108263

Summary:	glGetTexImage with PBO is not accelerated on Gallium
Product:	Mesa	Reporter:	Andrew Wesie <awesie>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED MOVED	QA Contact:	mesa-dev
Severity:	enhancement
Priority:	medium	CC:	fdsfgs, Hi-Angel, mirh
Version:	git
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Mesa patch for accelerated PBO texture downloads Patch for piglit for PBO texture download testcase

Description Andrew Wesie 2018-10-07 00:24:17 UTC

Created attachment 141925 [details] [review]
Mesa patch for accelerated PBO texture downloads

In May 2016, a patchset (https://lists.freedesktop.org/archives/mesa-dev/2016-May/117294.html) added acceleration for glReadPixels PBO downloads. Support for glGetTexImage and friends was left as future work.

As part of my efforts to find and fix performance hot spots in Wine's directx layer, I submitted patches to support texture downloads using PBOs in Wine. Unfortunately, on Mesa, this does not improve performance for the reason stated above.

It would be great if Mesa could add support for accelerated texture downloads using PBOs. In order to facilitate this, I put together a patch based on glReadPixels and a test case in piglit. I am not familiar with the Mesa code or conventions, but the patch passes the test case so it is probably close to correct.

Comment 1 Andrew Wesie 2018-10-07 00:24:45 UTC

Created attachment 141926 [details] [review]
Patch for piglit for PBO texture download testcase

Comment 2 GitLab Migration User 2019-09-18 20:27:21 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1030.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.