|Summary:||[CI][SHARDS] igt@kms_psr@no_drrs - fail - Failed assertion: drrs_disabled(&data)|
|Product:||DRI||Reporter:||Martin Peres <martin.peres>|
|Component:||DRM/Intel||Assignee:||Jose Roberto de Souza <jose.souza>|
|Status:||RESOLVED MOVED||QA Contact:||Intel GFX Bugs mailing list <intel-gfx-bugs>|
|Priority:||medium||CC:||intel-gfx-bugs, james.ausmus, radhakrishna.sripada|
|i915 platform:||ICL||i915 features:||display/PSR|
Description Martin Peres 2018-10-12 14:13:10 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_125/fi-icl-u/igt@kms_psr@no_drrs.html Starting subtest: no_drrs (kms_psr:1093) CRITICAL: Test assertion failure function main, file ../tests/kms_psr.c:439: (kms_psr:1093) CRITICAL: Failed assertion: drrs_disabled(&data) Subtest no_drrs failed.
Comment 1 Jose Roberto de Souza 2019-02-07 22:27:30 UTC
Will be fixed by https://patchwork.freedesktop.org/series/56369/
Comment 2 James Ausmus 2019-02-27 20:57:24 UTC
Did that series end up merging?
Comment 3 Martin Peres 2019-04-23 12:35:46 UTC
(In reply to James Ausmus from comment #2) > Did that series end up merging? It does not seem like it... Anyway, bumping the priority since it happens on shards!
Comment 4 James Ausmus 2019-04-24 23:28:21 UTC
From looking at the kms_psr.c test, the assert that is bailing out is only checking if DRRS is *supported* by the panel, rather than if DRRS is *enabled* by the driver. This is incorrect, and the test needs to be fixed. This is not a user impacting issue, but only an IGT issue
Comment 5 emersion 2019-06-11 07:44:29 UTC
(Not to be confused with https://bugs.freedesktop.org/show_bug.cgi?id=107383 which is a different failure in the same subtest) This bug only happens on one machine, shard-iclb1, where it always fails. It's hit weekly or so. (In reply to James Ausmus from comment #4) > From looking at the kms_psr.c test, the assert that is bailing out is only > checking if DRRS is *supported* by the panel, rather than if DRRS is > *enabled* by the driver. This is incorrect, and the test needs to be fixed. > > This is not a user impacting issue, but only an IGT issue Agreed. drrs_disabled needs to be fixed. CC'ing firstname.lastname@example.org since they last touched the check in commit 7c79e2ca1f78d.
Comment 6 Vanshidhar Konda 2019-10-31 18:21:47 UTC
Lowering the priority of the bug as it has been identified as a bug in the IGT test and occurs on only ICL platforms. It has no impact to the user.
Comment 7 Jose Roberto de Souza 2019-10-31 19:16:47 UTC
(In reply to Vanshidhar Konda from comment #6) > Lowering the priority of the bug as it has been identified as a bug in the > IGT test and occurs on only ICL platforms. It has no impact to the user. It will happen in any GEN8+ platform with a panel that supports PSR and DRRS. I have the fix but did not got reviews all the times that I sent it.
Comment 8 Martin Peres 2019-11-29 17:55:50 UTC
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/drm/intel/issues/173.