Bug 108532

Summary: make check nir_copy_prop_vars_test.store_store_load_different_components regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact: mesa-dev
Severity: normal    
Priority: medium CC: bas, jason
Version: gitKeywords: bisected, regression
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 108530    

Description Vinson Lee 2018-10-23 18:02:28 UTC 
====================================================
   Mesa 18.3.0-devel: src/compiler/test-suite.log
====================================================

# TOTAL: 10
# PASS:  9
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: nir/tests/vars_tests
==========================

Running main() from gtest_main.cc
[==========] Running 17 tests from 3 test cases.
[----------] Global test environment set-up.
[----------] 4 tests from nir_redundant_load_vars_test
[ RUN      ] nir_redundant_load_vars_test.duplicated_load
[       OK ] nir_redundant_load_vars_test.duplicated_load (0 ms)
[ RUN      ] nir_redundant_load_vars_test.duplicated_load_in_two_blocks
[       OK ] nir_redundant_load_vars_test.duplicated_load_in_two_blocks (0 ms)
[ RUN      ] nir_redundant_load_vars_test.invalidate_inside_if_block
[       OK ] nir_redundant_load_vars_test.invalidate_inside_if_block (0 ms)
[ RUN      ] nir_redundant_load_vars_test.invalidate_live_load_in_the_end_of_loop
[       OK ] nir_redundant_load_vars_test.invalidate_live_load_in_the_end_of_loop (0 ms)
[----------] 4 tests from nir_redundant_load_vars_test (0 ms total)

[----------] 7 tests from nir_copy_prop_vars_test
[ RUN      ] nir_copy_prop_vars_test.simple_copies
[       OK ] nir_copy_prop_vars_test.simple_copies (0 ms)
[ RUN      ] nir_copy_prop_vars_test.simple_store_load
[       OK ] nir_copy_prop_vars_test.simple_store_load (0 ms)
[ RUN      ] nir_copy_prop_vars_test.store_store_load
[       OK ] nir_copy_prop_vars_test.store_store_load (0 ms)
[ RUN      ] nir_copy_prop_vars_test.store_store_load_different_components
Assertion failed: (nir_src_num_components(src) == 1), function nir_src_as_uint, file nir/nir.c, line 1275.
FAIL nir/tests/vars_tests (exit status: 134)
Comment 1 Vinson Lee 2018-10-24 01:16:39 UTC 
16870de8a0aab97bd3534b660e7ea73e90ac11cd is the first bad commit
commit 16870de8a0aab97bd3534b660e7ea73e90ac11cd
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Sat Oct 20 09:10:02 2018 -0500

    nir: Use nir_src_is_const and nir_src_as_* in core code
    
    Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

:040000 040000 fbda312921231321d5edc1cce5285591f9091f1f ec69c85ecdeccbd82fabcd7b14da602a4bdb69a7 M	src
Comment 2 Juan A. Suarez 2018-10-24 07:16:00 UTC 
Fixed with:

commit 3112da346bd006876d9ac23a781b0a3d0a366653 (HEAD -> master, upstream/master, origin/master, origin/HEAD, jasuarez/fix-nir-test-v2)
Author: Juan A. Suarez Romero <jasuarez@igalia.com>
Date:   Tue Oct 23 15:55:11 2018 +0200

    nir: fix nir_copy_propagation test
    
    Use nir_src_comp_as_uint() to read the proper second component, as
    nir_src_as_uint() returns the first one.
    
    v2: Use nir_src_comp_as_uint() [Jason]
    
    Fixes: 16870de8a0a ("nir: Use nir_src_is_const and nir_src_as_* in core
                         code")
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108532
    Tested-by: Michel Dänzer <michel.daenzer@amd.com>
    Tested-by: Vinson Lee <vlee@freedesktop.org>
    Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

 src/compiler/nir/tests/vars_tests.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.