| Summary: | The spec@arb_program_interface_query@arb_program_interface_query-getprogramresourceiv fails | ||
|---|---|---|---|
| Product: | piglit | Reporter: | asimiklit <andrey.simiklit> |
| Component: | tests | Assignee: | Piglit Mailing List <piglit> |
| Status: | RESOLVED FIXED | QA Contact: | Piglit Mailing List <piglit> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
The possible solution: https://patchwork.freedesktop.org/patch/259513/ Fixed! --- 8< --- commit a96854e3406be69abca77e1e9ce63720e7a3c985 Author: Andrii Simiklit <andrii.simiklit@globallogic.com> Date: Wed Oct 31 17:05:56 2018 +0200 program_interface_query: don't expect a valid location for TCS output I guess we should not expect a valid location for: "patch out vec4 tcs_patch;" because this output variable is declareted without "layout (location=X)" and according to spec: "Not all active variables are assigned valid locations; the following variables will have an effective location of -1: * uniforms declared as atomic counters; * members of a uniform block; * built-in inputs, outputs, and uniforms (starting with "gl_"); and * inputs or outputs not declared with a "location" layout qualifier, except for vertex shader inputs and fragment shader outputs." Also I fixed some conflicting comments. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108612 Signed-off-by: Andrii Simiklit <andrii.simiklit@globallogic.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
I guess this piglit test fails because we require a valid location for TCS output which is declared without "layout (location=X)" but according to spec: "Not all active variables are assigned valid locations; the following variables will have an effective location of -1: * uniforms declared as atomic counters; * members of a uniform block; * built-in inputs, outputs, and uniforms (starting with "gl_"); and * inputs or outputs not declared with a "location" layout qualifier, except for vertex shader inputs and fragment shader outputs." I will provide the possible solution shortly.