Summary: | Support screen brightness adjustment button, the KEY_BRIGHTNESS_CYCLE EV_KEY | ||
---|---|---|---|
Product: | xkeyboard-config | Reporter: | jian-hong |
Component: | General | Assignee: | xkb |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | high | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | Patch for mapping evdev keycode KEY_BRIGHTNESS_CYCLE to XF86MonBrightnessCycle |
Description
jian-hong
2018-11-26 02:51:15 UTC
I also checked with xev: KeyPress event, serial 38, synthetic NO, window 0x2600001, root 0x177, subw 0x0, time 3371132, (225,-51), root:(275,35), state 0x10, keycode 251 (keysym 0x0, NoSymbol), same_screen YES, XLookupString gives 0 bytes: XmbLookupString gives 0 bytes: XFilterEvent returns: False KeyRelease event, serial 38, synthetic NO, window 0x2600001, root 0x177, subw 0x0, time 3371132, (225,-51), root:(275,35), state 0x10, keycode 251 (keysym 0x0, NoSymbol), same_screen YES, XLookupString gives 0 bytes: XFilterEvent returns: False The key code is 251, but no corresponding symbol. Then checked "/usr/share/X11/xkb/symbols/inet" // key <I249> { [ ] }; // KEY_VIDEO_NEXT -- drive next video source // key <I250> { [ ] }; // KEY_VIDEO_PREV -- drive previous video source // key <I251> { [ ] }; // KEY_BRIGHTNESS_CYCLE -- bright up, max++ == min // key <I252> { [ ] }; // KEY_BRIGHTNESS_ZERO -- brightness off // key <I253> { [ ] }; // KEY_DISPLAY_OFF -- turn off display There is no symbol of key code 251, but the comment says it is KEY_BRIGHTNESS_CYCLE. May we add the mapping symbol of the key code 251 for KEY_BRIGHTNESS_CYCLE? Then we could make gnome-settings-daemon respond to that key, treating it as either a brightness cycle key for simplicity, to avoid having to implement a brightness change UI. By the way, I also reported this bug on gnome-settings-daemon https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/117 Sent a patch for adding XF86XK_MonBrightnessCycle -> XF86MonBrightnessCycle in xorgproto https://lists.x.org/archives/xorg-devel/2018-November/057764.html Created attachment 142641 [details] [review] Patch for mapping evdev keycode KEY_BRIGHTNESS_CYCLE to XF86MonBrightnessCycle -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/issues/123. Patch merged, changing resolution to fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.