| Summary: | Test enumeration becomes funky on some tests due to fd FILE* stream change | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Casey Bowman <casey.g.bowman> |
| Component: | IGT | Assignee: | Default DRI bug account <dri-devel> |
| Status: | RESOLVED MOVED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | casey.g.bowman |
| Version: | XOrg git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Casey Bowman
2018-11-28 21:13:05 UTC
Note that the invalid argument error is most likely an unrelated error, but most likely attributed to this bug being found. Different subgroup, not affecting basic-busy-default, but rightfully preventing you from running any of the hang tests. diff --git a/lib/igt_core.c b/lib/igt_core.c
index e0989f53..bd600762 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -1116,30 +1116,28 @@ void igt_fail(int exitcode)
if (in_atexit_handler)
_exit(IGT_EXIT_FAILURE);
- if (!failed_one)
- igt_exitcode = exitcode;
-
- failed_one = true;
-
/* Silent exit, parent will do the yelling. */
if (test_child)
exit(exitcode);
+ if (in_fixture) {
+ skip_subtests_henceforth = FAIL;
+ __igt_fixture_end();
+ }
+
_igt_log_buffer_dump();
+ if (!failed_one) {
+ igt_exitcode = exitcode;
+ failed_one = true;
+ }
+
if (in_subtest) {
if (exitcode == IGT_EXIT_TIMEOUT)
exit_subtest("TIMEOUT");
else
exit_subtest("FAIL");
} else {
- assert(igt_can_fail());
-
- if (in_fixture) {
- skip_subtests_henceforth = FAIL;
- __igt_fixture_end();
- }
-
igt_exit();
}
}
Just a very misleading bisect. (In reply to Chris Wilson from comment #4) > Just a very misleading bisect. Agreed, the commit found would probably just cause the gem -hang tests to fail in the kernel we're using as you mentioned earlier. However, for the cases in which a basic subtest is run (for example, igt@gem_busy@basic-busy-default or igt@gem_exec_reloc@basic-cpu) there shouldn't be any hang checks (igt_allow_hang) for the requirements of those subtests, right? If so, should we change the bug title to reflect that some requirement checks are being run on subtests that don't reflect the subtest names, like how igt@gem_busy@basic-busy-default doesn't have 'hang' in it? -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/11. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.