Bug 109082

Summary: meson lmsensors check fails but always returns true
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact: mesa-dev
Severity: normal    
Priority: medium CC: baker.dylan.c
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2018-12-18 02:48:04 UTC
meson -Dlmsensors=true

This is returned even though libsensors is not found.
Library libsensors found: YES

meson-log.txt
[...]
Working directory:  /tmp/tmp6w0ai2pa
Command line:  cc /tmp/tmp6w0ai2pa/testfile.c -pipe -D_FILE_OFFSET_BITS=64 -o /tmp/tmp6w0ai2pa/output.exe -O0 -Wl,--start-group -llibsensors -Wl,--end-gr
oup -Wl,--allow-shlib-undefined 

Code:
 int main(int argc, char **argv) { return 0; }
Compiler stdout:
 
Compiler stderr:
 /usr/bin/ld: cannot find -llibsensors
collect2: error: ld returned 1 exit status
Comment 1 Vinson Lee 2019-01-14 04:08:11 UTC
commit 0f7ba5758bd8a3e12b8b33ab471336eaa7dd6fbc
Author: Vinson Lee <vlee@freedesktop.org>
Date:   Tue Dec 18 09:42:04 2018 -0800

    meson: Fix libsensors detection.
    
    Fixes: 5e71efef44b9 ("meson: Add lmsensors support")
    Signed-off-by: Vinson Lee <vlee@freedesktop.org>
    Reviewed-by: Dylan Baker <dylan@pnwbakers.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.