Bug 109481

Summary: [CI][DRMTIP] igt@gem_exec_capture@* - fail - Failed assertion: found, Last errno: 19, No such device
Product: DRI Reporter: Martin Peres <martin.peres>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs
Version: XOrg git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: BSW/CHT i915 features: GEM/Other

Description Martin Peres 2019-01-28 13:41:30 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_201/fi-bsw-n3050/igt@gem_exec_capture@userptr.html

Starting subtest: userptr
(gem_exec_capture:1263) CRITICAL: Test assertion failure function check_error_state, file ../tests/i915/gem_exec_capture.c:61:
(gem_exec_capture:1263) CRITICAL: Failed assertion: found
(gem_exec_capture:1263) CRITICAL: Last errno: 19, No such device
Comment 1 CI Bug Log 2019-01-28 13:42:16 UTC
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* BSW: igt@gem_exec_capture@* - fail - Failed assertion: found, Last errno: 19, No such device
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_196/fi-bsw-n3050/igt@gem_exec_capture@capture-vebox.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_196/fi-bsw-n3050/igt@gem_exec_capture@capture-blt.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_196/fi-bsw-n3050/igt@gem_exec_capture@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_197/fi-bsw-n3050/igt@gem_exec_capture@capture-vebox.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_197/fi-bsw-n3050/igt@gem_exec_capture@capture-blt.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_197/fi-bsw-n3050/igt@gem_exec_capture@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_197/fi-bsw-n3050/igt@gem_exec_capture@capture-bsd.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_197/fi-bsw-n3050/igt@gem_exec_capture@capture-render.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_198/fi-bsw-n3050/igt@gem_exec_capture@capture-bsd.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_198/fi-bsw-n3050/igt@gem_exec_capture@capture-blt.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_198/fi-bsw-n3050/igt@gem_exec_capture@capture-render.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_198/fi-bsw-n3050/igt@gem_exec_capture@capture-vebox.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_198/fi-bsw-n3050/igt@gem_exec_capture@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_199/fi-bsw-n3050/igt@gem_exec_capture@capture-bsd.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_199/fi-bsw-n3050/igt@gem_exec_capture@capture-vebox.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_199/fi-bsw-n3050/igt@gem_exec_capture@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_200/fi-bsw-n3050/igt@gem_exec_capture@capture-bsd.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_200/fi-bsw-n3050/igt@gem_exec_capture@capture-blt.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_200/fi-bsw-n3050/igt@gem_exec_capture@capture-vebox.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_200/fi-bsw-n3050/igt@gem_exec_capture@userptr.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_201/fi-bsw-n3050/igt@gem_exec_capture@capture-bsd.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_201/fi-bsw-n3050/igt@gem_exec_capture@capture-blt.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_201/fi-bsw-n3050/igt@gem_exec_capture@capture-vebox.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_201/fi-bsw-n3050/igt@gem_exec_capture@userptr.html
Comment 2 Chris Wilson 2019-01-30 09:56:16 UTC
commit 96c2dfbbb2c10cd92ddc9fe22993371bc3ba36a1
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Jan 29 11:17:41 2019 +0000

    i915/gem_exec_capture: Check the strlen() for an empty file
    
    igt_sysfs_get() only returns NULL if the open() fails, and a valid
    string otherwise. So if the read() fails with ENODEV (because sysfs
    doesn't provide the driver with an ->open() callback), we return an
    empty string, and "No error captured" otherwise.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109481
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

This time for sure!
Comment 3 Martin Peres 2019-03-06 18:55:14 UTC
(In reply to Chris Wilson from comment #2)
> commit 96c2dfbbb2c10cd92ddc9fe22993371bc3ba36a1
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Tue Jan 29 11:17:41 2019 +0000
> 
>     i915/gem_exec_capture: Check the strlen() for an empty file
>     
>     igt_sysfs_get() only returns NULL if the open() fails, and a valid
>     string otherwise. So if the read() fails with ENODEV (because sysfs
>     doesn't provide the driver with an ->open() callback), we return an
>     empty string, and "No error captured" otherwise.
>     
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109481
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>     Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>
> 
> This time for sure!

Looks good! Thanks!
Comment 4 CI Bug Log 2019-03-06 18:55:24 UTC
The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.