Bug 10964

Summary:	rtppayloads broken when g729 is enabled
Product:	Farstream	Reporter:	Sebastian Dröge (slomo) <slomo>
Component:	GStreamer Elements	Assignee:	Philippe Khalaf <philippe.kalaf>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	highest
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Sebastian Dröge (slomo) 2007-05-16 03:12:16 UTC

Hi,
the Makefile.am magic to append the g729 sources when ENABLE_G729 is broken. No idea how to fix this but this results in an unloadable plugin library as the g729 functions are called at plugin init but are not linked in.

You should probably use -Wl,--no-undefined when linking to prevent such errors from going unnoticed in the future.

Bye

Comment 1 Philippe Khalaf 2007-05-17 13:15:55 UTC

Fixed in darcs head, will be available in next release (0.12.2).

diff -rN -u -p old-gst-plugins-farsight-misc-fixes/configure.ac new-gst-plugins-farsight-misc-fixes/configure.ac
--- old-gst-plugins-farsight-misc-fixes/configure.ac 2007-05-04 23:05:26.322807166 +0100
+++ new-gst-plugins-farsight-misc-fixes/configure.ac 2007-05-04 23:05:26.452816748 +0100
@@ -336,7 +336,9 @@ AC_ARG_ENABLE([g729],
 
 AC_MSG_RESULT(Checking for --enable-g729... $g729)
 AM_CONDITIONAL(ENABLE_G729, test "x$g729" != "xno")
-AC_DEFINE(ENABLE_G729, , [Compile the G729 payloader and depayloader])
+if test "x$g729" != "xno"; then
+   AC_DEFINE(ENABLE_G729, , [Compile the G729 payloader and depayloader])
+fi
 
 AC_OUTPUT(Makefile \
 ext/Makefile \

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.