Bug 109674

Summary: [CI][SHARDS] igt@gem_ctx_param@invalid-param-set - fail - Failed assertion: __gem_context_set_param(fd, &arg) == -22
Product: DRI Reporter: Martin Peres <martin.peres>
Component: DRM/IntelAssignee: Chris Wilson <chris>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs
Version: XOrg git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: ALL i915 features: GEM/Other

Description Martin Peres 2019-02-19 09:35:45 UTC 
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5626/shard-glk9/igt@gem_ctx_param@invalid-param-set.html

Starting subtest: invalid-param-set
(gem_ctx_param:2415) CRITICAL: Test assertion failure function __real_main146, file ../tests/i915/gem_ctx_param.c:312:
(gem_ctx_param:2415) CRITICAL: Failed assertion: __gem_context_set_param(fd, &arg) == -22
(gem_ctx_param:2415) CRITICAL: error: 0 != -22
Comment 1 Chris Wilson 2019-02-19 09:37:09 UTC 
The test is designed to fail. An utter waste of time.
Comment 2 CI Bug Log 2019-02-19 09:37:46 UTC 
The CI Bug Log issue associated to this bug has been updated.

### New filters associated

* all machines: igt@gem_ctx_param@invalid-param-set - fail - Failed assertion: __gem_context_set_param(fd, &amp;arg) == -22
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3817/shard-apl4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3817/shard-glk7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3817/shard-hsw3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3817/shard-kbl5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12155/shard-apl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12155/shard-glk1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12155/shard-hsw1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12155/shard-kbl2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3829/shard-apl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3829/shard-glk5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3829/shard-hsw5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3829/shard-kbl4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3829/shard-snb5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3831/shard-apl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3831/shard-glk6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3831/shard-hsw8/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3831/shard-kbl4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3831/shard-snb4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3860/shard-apl6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3860/shard-glk4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3860/shard-hsw2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3860/shard-iclb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3860/shard-kbl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3860/shard-snb5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12240/shard-apl6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12240/shard-glk3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12240/shard-hsw5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12240/shard-iclb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12240/shard-kbl4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12240/shard-snb7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12244/shard-apl2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12244/shard-glk8/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12244/shard-hsw6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12244/shard-iclb4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12244/shard-kbl1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5626/shard-apl6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5626/shard-glk9/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5626/shard-hsw3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5626/shard-iclb5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5626/shard-kbl6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5626/shard-skl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5626/shard-snb7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2438/shard-apl1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2438/shard-glk8/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2438/shard-hsw8/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2438/shard-kbl5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2438/shard-snb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12248/shard-apl1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12248/shard-glk7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12248/shard-hsw6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12248/shard-iclb4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12248/shard-kbl3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12248/shard-snb5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12249/shard-apl6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12249/shard-glk7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12249/shard-hsw3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12249/shard-iclb5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12249/shard-kbl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12249/shard-snb7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2439/shard-apl6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2439/shard-glk1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2439/shard-hsw2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2439/shard-kbl6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2439/shard-snb2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4836/shard-glk4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4836/shard-hsw2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4836/shard-kbl1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4836/shard-skl6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4836/shard-snb6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5627/shard-apl2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5627/shard-glk6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5627/shard-hsw3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5627/shard-kbl2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5627/shard-skl9/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5627/shard-snb5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12250/shard-apl4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12250/shard-glk9/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12250/shard-hsw1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12250/shard-kbl1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12250/shard-snb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5628/shard-apl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5628/shard-glk2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5628/shard-hsw3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5628/shard-kbl5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5628/shard-skl3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5628/shard-snb7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5629/shard-apl1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5629/shard-glk5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5629/shard-hsw2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5629/shard-kbl4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5629/shard-skl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_5629/shard-snb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3863/shard-glk6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3863/shard-hsw3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3863/shard-kbl1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3863/shard-snb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3864/shard-apl4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3864/shard-glk6/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3864/shard-hsw7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3864/shard-kbl2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3864/shard-snb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3865/shard-apl3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3865/shard-glk3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3865/shard-hsw1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3865/shard-kbl5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3865/shard-snb7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3866/shard-apl3/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3866/shard-glk7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3866/shard-hsw8/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3866/shard-kbl5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3866/shard-snb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3867/shard-apl1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3867/shard-glk4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3867/shard-hsw2/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3867/shard-kbl7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_3867/shard-snb1/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12252/shard-apl4/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12252/shard-glk7/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12252/shard-hsw5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12252/shard-kbl5/igt@gem_ctx_param@invalid-param-set.html
  - https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12252/shard-snb2/igt@gem_ctx_param@invalid-param-set.html
Comment 3 Francesco Balestrieri 2019-03-01 12:17:03 UTC 
https://patchwork.freedesktop.org/patch/286767/ fixes this by removing the test.
Comment 4 Chris Wilson 2019-03-26 10:36:19 UTC 
commit 2551ed1864985d2fe1c250337f86c7b2bc670c67 (upstream/master, origin/master, origin/HEAD)
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Feb 18 12:25:50 2019 +0000

    i915/gem_ctx_param: Remove kneecapping
    
    The invalid set/get tests do not serve the purpose of detecting whether
    or not invalid parameters are indeed detected correctly -- simply because
    the kernel is the arbiter of what is invalid and this test second
    guesses that and is wrong.
    
    The intent of this test was to ensure that we didn't include any holes
    in the parameter space that may have been used for nefarious undisclosed
    purposes, i.e. the maintainer's job backed up by reviewers.
    
    As proving no holes is impossible without fuzzing/exhaustive search and
    a whitelist, accept defeat and just check whether the very last
    parameter (which should be unused for a long, long time) is invalid.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Comment 5 Martin Peres 2019-04-04 13:21:36 UTC 
(In reply to Chris Wilson from comment #4)
> commit 2551ed1864985d2fe1c250337f86c7b2bc670c67 (upstream/master,
> origin/master, origin/HEAD)
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Mon Feb 18 12:25:50 2019 +0000
> 
>     i915/gem_ctx_param: Remove kneecapping
>     
>     The invalid set/get tests do not serve the purpose of detecting whether
>     or not invalid parameters are indeed detected correctly -- simply because
>     the kernel is the arbiter of what is invalid and this test second
>     guesses that and is wrong.
>     
>     The intent of this test was to ensure that we didn't include any holes
>     in the parameter space that may have been used for nefarious undisclosed
>     purposes, i.e. the maintainer's job backed up by reviewers.
>     
>     As proving no holes is impossible without fuzzing/exhaustive search and
>     a whitelist, accept defeat and just check whether the very last
>     parameter (which should be unused for a long, long time) is invalid.
>     
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>     Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>     Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Thanks, it definitely fixed the issues. It used to be 100% reproducible but not anymore. Last seen on CI_DRM_5814_full (1 week, 1 day old).
Comment 6 CI Bug Log 2019-04-04 13:21:43 UTC 
The CI Bug Log issue associated to this bug has been archived.

New failures matching the above filters will not be associated to this bug anymore.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.