Bug 110248

Summary:	IGT Meson build fails when "-Dbuild_tests=false" option is used
Product:	DRI	Reporter:	Eero Tamminen <eero.t.tamminen>
Component:	IGT	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	DRI git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Eero Tamminen 2019-03-26 12:36:40 UTC

Setup:
* Ubuntu 18.04
* IGT git master

Test-case:
* meson -Dbuild_tests=false /path/to/repo/

Expected outcome:
* I can build just tooling from IGT

Actual outcome:
* runner/testdata/meson.build:15:0: ERROR:  Unknown variable "gen_testlist".

Comment 1 Petri Latvala 2019-05-10 10:55:38 UTC

commit 159c69e5318e934b5f1d83939191c8756280b758
Author: Petri Latvala <petri.latvala@intel.com>
Date:   Fri Apr 26 14:05:41 2019 +0300

    runner: Disable building if tests are not built

Comment 2 Eero Tamminen 2019-05-10 11:28:43 UTC

Thanks, I can verify that the Meson doesn't anymore fail.

However, it doesn't seem to disable all tests:
----------------------------------------------------------------
$ grep tests intel-gpu-tools_build.log
Message: Build tests: No
[3/328] Compiling C object 'lib/tests/lib@tests@@igt_can_fail_simple@exe/igt_can_fail_simple.c.o'.
[4/328] Compiling C object 'lib/tests/lib@tests@@igt_timeout@exe/igt_timeout.c.o'.
[5/328] Compiling C object 'lib/tests/lib@tests@@igt_can_fail@exe/igt_can_fail.c.o'.
[6/328] Compiling C object 'lib/tests/lib@tests@@igt_no_subtest@exe/igt_no_subtest.c.o'.
[7/328] Compiling C object 'lib/tests/lib@tests@@igt_simple_test_subtests@exe/igt_simple_test_subtests.c.o'.
[8/328] Compiling C object 'lib/tests/lib@tests@@igt_list_only@exe/igt_list_only.c.o'.
[10/328] Compiling C object 'lib/tests/lib@tests@@igt_fork_helper@exe/igt_fork_helper.c.o'.
[11/328] Compiling C object 'lib/tests/lib@tests@@igt_invalid_subtest_name@exe/igt_invalid_subtest_name.c.o'.
[12/328] Compiling C object 'lib/tests/lib@tests@@igt_segfault@exe/igt_segfault.c.o'.
[15/328] Compiling C object 'lib/tests/lib@tests@@igt_no_exit@exe/igt_no_exit.c.o'.
[17/328] Compiling C object 'lib/tests/lib@tests@@igt_fork@exe/igt_fork.c.o'.
[18/328] Compiling C object 'lib/tests/lib@tests@@igt_subtest_group@exe/igt_subtest_group.c.o'.
[22/328] Compiling C object 'lib/tests/lib@tests@@igt_exit_handler@exe/igt_exit_handler.c.o'.
[23/328] Compiling C object 'lib/tests/lib@tests@@igt_simulation@exe/igt_simulation.c.o'.
[30/328] Compiling C object 'lib/tests/lib@tests@@igt_hdmi_inject@exe/igt_hdmi_inject.c.o'.
[37/328] Compiling C object 'lib/tests/lib@tests@@igt_stats@exe/igt_stats.c.o'.
[45/328] Compiling C object 'lib/tests/lib@tests@@igt_assert@exe/igt_assert.c.o'.
----------------------------------------------------------------

Are these built on purpose even with tests building disabled?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.