Summary: | "glx: Fix synthetic error generation in __glXSendError" broke wine games on 32-bit | ||
---|---|---|---|
Product: | Mesa | Reporter: | Andrew Randrianasulu <randrik> |
Component: | GLX | Assignee: | mesa-dev |
Status: | RESOLVED FIXED | QA Contact: | mesa-dev |
Severity: | normal | ||
Priority: | medium | CC: | Hi-Angel, zegentzy |
Version: | git | ||
Hardware: | x86 (IA32) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | apitrace from failed run (mesa git without revert) |
Description
Andrew Randrianasulu
2019-05-07 03:44:39 UTC
Is it possible to get a backtrace from __glXSendError? I don't understand why this particular commit would change behavior from "not error" to "error". Created attachment 144184 [details]
apitrace from failed run (mesa git without revert)
(In reply to Ian Romanick from comment #1) > Is it possible to get a backtrace from __glXSendError? I don't understand > why this particular commit would change behavior from "not error" to "error". sorry, not familiar enough with gdb. Should I set breakpoint somewhere in libGL? (In reply to Andrew Randrianasulu from comment #2) > Created attachment 144184 [details] > apitrace from failed run (mesa git without revert) hm, last line from apitrace: 12665 glXCreateContextAttribsARB(dpy = 0x7cbb2e18, config = 0x7c880b90, share_context = NULL, direct = True, attrib_list = {GLX_CONTEXT_MAJOR_VERSION_ARB, 4, GLX_CONTEXT_MINOR_VERSION_ARB, 4, 0}) // incomplete does this mean it tries to create 4.4 core context? If so, my hardware doesn't support this (nv92 with nouveau drivers, only up to OpenGL 3.3) *** Bug 110590 has been marked as a duplicate of this bug. *** (In reply to Ian Romanick from comment #1) > Is it possible to get a backtrace from __glXSendError? I don't understand > why this particular commit would change behavior from "not error" to "error". Sure, can you tell offhand though, in which line can I set an "abort()" to cause a core dump on the error? I tried to get a stacktrace both from gdb and winedbg, but for various reasons neither works. I've reverted this for now. We can try again later once this regression is figured out. commit a01b393c397c846345f03f76f1167dd667e0ee96 Author: Timothy Arceri <tarceri@itsqueeze.com> Date: Tue May 7 13:55:32 2019 +1000 Revert "glx: Fix synthetic error generation in __glXSendError" This reverts commit e91ee763c378d03883eb88cf0eadd8aa916f7878. This seems to have broken a number of wine games. Lets revert everything for now and try again later. Acked-by: Adam Jackson <ajax@redhat.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110632 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110590 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.