Bug 110831

Summary: [AMD TAHITI XT][amd-staging-drm-next][bisected] broken since 5.2-rc1 rebase
Product: DRI Reporter: Sylvain BERTRAND <sylvain.bertrand>
Component: DRM/AMDgpuAssignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: highest CC: Emily.Deng
Version: DRI git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg
none
xorg
none
possible fix none

Description Sylvain BERTRAND 2019-06-03 16:03:54 UTC
xorg amdgpu driver initing hangs the system with 5.2-rc1 rebased amd-staging-drm-next linux kernel.

Yes I can bisect. Stay tuned.
Comment 1 Sylvain BERTRAND 2019-06-03 18:35:44 UTC
The guilty commit is following. I reverted this commit on top of the current amd-staging-drm-next (40cc64619a2580b26f924bcabdefd555e7831a14), my system is then booting ok. It seems to do some specific programming for vega10+ parts which is not correct for previous families/versions parts.

commit 43ee614432d841184b158af27fda66a0929fe252 (refs/bisect/bad)
Author: Emily Deng <Emily.Deng@amd.com>
Date:   Tue May 28 10:17:04 2019 +0800

    drm/amdgpu: Need to set the baco cap before baco reset

    For passthrough, after rebooted the VM, driver will do
    a baco reset before doing other driver initialization during loading
     driver. For doing the baco reset, it will first
    check the baco reset capability. So first need to set the
    cap from the vbios information or baco reset won't be
    enabled.

    Signed-off-by: Emily Deng <Emily.Deng@amd.com>
    Reviewed-by: Evan Quan <evan.quan@amd.com>
Comment 2 Sylvain BERTRAND 2019-06-03 18:37:12 UTC
Created attachment 144429 [details]
dmesg
Comment 3 Sylvain BERTRAND 2019-06-03 18:39:17 UTC
Created attachment 144430 [details]
xorg
Comment 4 Alex Deucher 2019-06-17 14:43:39 UTC
Created attachment 144570 [details] [review]
possible fix

Does this patch help?
Comment 5 Sylvain BERTRAND 2019-06-18 11:06:19 UTC
Did update the amd-staging-drm-next branch earlier today. The hanging boot is
gone. Did a quick check: your patch was already applied. So it probably did fix
it.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.