| Summary: | [CI][SHARDS] igt@gem_ctx_(clone|param)@vm - dmesg-warn - GEM_BUG_ON(i915_vma_is_pinned(vma)) | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Martin Peres <martin.peres> |
| Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | normal | ||
| Priority: | high | CC: | intel-gfx-bugs, lakshminarayana.vudum |
| Version: | XOrg git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | ReadyForDev | ||
| i915 platform: | BYT, HSW, IVB | i915 features: | GEM/Other |
|
Description
Martin Peres
2019-06-04 14:00:40 UTC
The CI Bug Log issue associated to this bug has been updated. ### New filters associated * HSW: igt@gem_ctx_(clone|param)@vm - dmesg-warn - GEM_BUG_ON(i915_vma_is_pinned(vma)) - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5032/shard-hsw1/igt@gem_ctx_clone@vm.html - https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5032/shard-hsw5/igt@gem_ctx_param@vm.html commit 1fe2d6f94f96e35f0d71721eb899f5f72d5b68bd Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Tue Jun 4 16:24:08 2019 +0100 drm/i915: Skip context_barrier emission for unused contexts The intent was to skip unused HW contexts by checking ce->state. However, this only works for execlists where the ppGTT pointers is stored inside the HW context. For gen7, the ppGTT is alongside the logical state and must be updated on all active engines but, crucially, only on active engines. As we need different checks, and to keep context_barrier_task() agnostic, pass in the predicate. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110836 Fixes: 62c8e423450d ("drm/i915: Skip unused contexts for context_barrier_task()") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190604152408.24468-1-chris@chris-wilson.co.uk *** Bug 110875 has been marked as a duplicate of this bug. *** A CI Bug Log filter associated to this bug has been updated:
{- HSW: igt@gem_ctx_(clone|param)@vm - dmesg-warn - GEM_BUG_ON(i915_vma_is_pinned(vma)) -}
{+ BYT IVB HSW: igt@gem_ctx_(clone|param)@vm - dmesg-warn - GEM_BUG_ON(i915_vma_is_pinned(vma)) +}
No new failures caught with the new filter
The CI Bug Log issue associated to this bug has been archived. New failures matching the above filters will not be associated to this bug anymore. (In reply to Chris Wilson from comment #3) > commit 1fe2d6f94f96e35f0d71721eb899f5f72d5b68bd > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Tue Jun 4 16:24:08 2019 +0100 > > drm/i915: Skip context_barrier emission for unused contexts > > The intent was to skip unused HW contexts by checking ce->state. > However, this only works for execlists where the ppGTT pointers is > stored inside the HW context. For gen7, the ppGTT is alongside the > logical state and must be updated on all active engines but, crucially, > only on active engines. As we need different checks, and to keep > context_barrier_task() agnostic, pass in the predicate. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110836 > Fixes: 62c8e423450d ("drm/i915: Skip unused contexts for > context_barrier_task()") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Link: > https://patchwork.freedesktop.org/patch/msgid/20190604152408.24468-1- > chris@chris-wilson.co.uk Thanks! It fixed the issue :) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.