Bug 111078

Summary: Android build error after 38305e6c ("anv: replace hard-coded platform list with vk.xml parse")
Product: Mesa Reporter: Mauro Rossi <issor.oruam>
Component: Drivers/Vulkan/intelAssignee: Intel 3D Bugs Mailing List <intel-3d-bugs>
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: blocker    
Priority: medium CC: clayton.a.craft, fdo-bugs, jason
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: other   
Whiteboard:
i915 platform: i915 features:

Description Mauro Rossi 2019-07-06 20:25:19 UTC
The following building error are happening with Android build system,
reverting commit 38305e6c ("anv: replace hard-coded platform list with vk.xml parse") fixes the problem.


out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:144:19: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
   .KHR_display = VK_USE_PLATFORM_DISPLAY_KHR,
                  ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:148:35: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
   .KHR_get_display_properties2 = VK_USE_PLATFORM_DISPLAY_KHR,
                                  ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:150:37: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
   .KHR_get_surface_capabilities2 = ANV_HAS_SURFACE,
                                    ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:111:187: note: expanded from macro 'ANV_HAS_SURFACE'
#define ANV_HAS_SURFACE (VK_USE_PLATFORM_WAYLAND_KHR ||                          VK_USE_PLATFORM_XCB_KHR ||                          VK_USE_PLATFORM_XLIB_KHR ||                          VK_USE_PLATFORM_DISPLAY_KHR)
                                                                                                                                                                                          ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:151:19: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
   .KHR_surface = ANV_HAS_SURFACE,
                  ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:111:187: note: expanded from macro 'ANV_HAS_SURFACE'
#define ANV_HAS_SURFACE (VK_USE_PLATFORM_WAYLAND_KHR ||                          VK_USE_PLATFORM_XCB_KHR ||                          VK_USE_PLATFORM_XLIB_KHR ||                          VK_USE_PLATFORM_DISPLAY_KHR)
                                                                                                                                                                                          ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:152:42: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
   .KHR_surface_protected_capabilities = ANV_HAS_SURFACE,
                                         ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:111:187: note: expanded from macro 'ANV_HAS_SURFACE'
#define ANV_HAS_SURFACE (VK_USE_PLATFORM_WAYLAND_KHR ||                          VK_USE_PLATFORM_XCB_KHR ||                          VK_USE_PLATFORM_XLIB_KHR ||                          VK_USE_PLATFORM_DISPLAY_KHR)
                                                                                                                                                                                          ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:158:31: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
   .EXT_direct_mode_display = VK_USE_PLATFORM_DISPLAY_KHR,
                              ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:159:35: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
   .EXT_display_surface_counter = VK_USE_PLATFORM_DISPLAY_KHR,
                                  ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:273:34: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
      .KHR_incremental_present = ANV_HAS_SURFACE,
                                 ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:111:187: note: expanded from macro 'ANV_HAS_SURFACE'
#define ANV_HAS_SURFACE (VK_USE_PLATFORM_WAYLAND_KHR ||                          VK_USE_PLATFORM_XCB_KHR ||                          VK_USE_PLATFORM_XLIB_KHR ||                          VK_USE_PLATFORM_DISPLAY_KHR)
                                                                                                                                                                                          ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:286:24: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
      .KHR_swapchain = ANV_HAS_SURFACE,
                       ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:111:187: note: expanded from macro 'ANV_HAS_SURFACE'
#define ANV_HAS_SURFACE (VK_USE_PLATFORM_WAYLAND_KHR ||                          VK_USE_PLATFORM_XCB_KHR ||                          VK_USE_PLATFORM_XLIB_KHR ||                          VK_USE_PLATFORM_DISPLAY_KHR)
                                                                                                                                                                                          ^
out/target/product/x86_64/obj_x86/STATIC_LIBRARIES/libmesa_vulkan_common_intermediates/vulkan/anv_extensions.c:294:30: error: use of undeclared identifier 'VK_USE_PLATFORM_DISPLAY_KHR'
      .EXT_display_control = VK_USE_PLATFORM_DISPLAY_KHR,
                             ^
10 errors generated.
Comment 1 Lionel Landwerlin 2019-07-07 08:49:26 UTC
Thanks for reporting this : https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1272/
Comment 2 Lionel Landwerlin 2019-07-07 13:00:39 UTC
Should be fixed in https://gitlab.freedesktop.org/mesa/mesa/commit/5493ec3c199b3190dc5d247d9e2a0eccd5066cf2

I'll study having a container to have an Android build in the CI pipelines.
Comment 3 Mark Janes 2019-07-08 04:40:29 UTC
Lionel, we are building android as part of CI.

Clayton: any idea why this wasn't caught by Intel's CI?
Comment 4 Lionel Landwerlin 2019-07-08 07:49:19 UTC
(In reply to Mark Janes from comment #3)
> Lionel, we are building android as part of CI.
> 
> Clayton: any idea why this wasn't caught by Intel's CI?

It's possible that Eric didn't run this through CI.
I figured we could at least provide a quick "Does it even build" pipeline on fdo (much like there are for other scons, etc... builds).
Comment 5 Eric Engestrom 2019-07-08 09:43:10 UTC
(In reply to Lionel Landwerlin from comment #4)
> (In reply to Mark Janes from comment #3)
> > Lionel, we are building android as part of CI.
> > 
> > Clayton: any idea why this wasn't caught by Intel's CI?
> 
> It's possible that Eric didn't run this through CI.

Indeed, I didn't think to run this MR through our CI, apologies for that.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.