Bug 111151

Summary:	vkGetRandROutputDisplayEXT returns VK_SUCCESS on failure
Product:	Mesa	Reporter:	Drew DeVault <sir>
Component:	Drivers/Vulkan/Common	Assignee:	mesa-dev
Status:	RESOLVED NOTABUG	QA Contact:
Severity:	normal
Priority:	medium	CC:	airlied, chadversary, jason, keithp, sir
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Drew DeVault 2019-07-16 21:28:34 UTC

If the output does not have a CONNECTOR_ID atom, then this function fails (giving back a 0 VkDisplayKHR) but it returns VK_SUCCESS nonetheless.

Passing this VkDisplayKHR into vkAcquireXlibDisplayEXT later then segfaults mesa.

Comment 1 Lionel Landwerlin 2019-07-17 07:58:30 UTC

There is an MR opened about this : https://gitlab.freedesktop.org/mesa/mesa/merge_requests/385

Unfortunately we need a spec update first as there is no error code defined for this function to fail. There is an issue opened about this on the khronos group gitlab.

I think the behavior of the driver follows the spec, so I will close.
When the spec is updated we'll update the driver.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.