Summary: | [DXVK][Regression][BISECTED][SKL] Everything is too bright on Elite Dangerous | ||
---|---|---|---|
Product: | Mesa | Reporter: | leozinho29_eu |
Component: | Drivers/Vulkan/intel | Assignee: | Ian Romanick <idr> |
Status: | RESOLVED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
Severity: | normal | ||
Priority: | medium | CC: | idr, jason |
Version: | git | Keywords: | bisected, regression |
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
Screenshots
apitrace (compressed) |
Description
leozinho29_eu
2019-07-17 00:24:52 UTC
Bisected commit points to Ian's new comparison re=materialization pass: https://gitlab.freedesktop.org/mesa/mesa/commit/65df6122da9d171bc44f9ca969825478543b5384 Can you provide a D3D apitrace file which reproduces the issue? Created attachment 144806 [details]
apitrace (compressed)
Here is the apitrace. As this particular bug is already visible in the main menu, there is no need to go further in the game.
Fixed by the following commit in master: jason@omlet% git show ~/projects/mesa/master commit 6301f80b840d50f2f8ec4fc46adfe8ad43da53ab (HEAD -> master, origin/master, origin/HEAD) Author: Jason Ekstrand <jason@jlekstrand.net> Date: Fri Jul 19 13:07:39 2019 -0500 nir: Only rematerialize comparisons with all SSA sources Otherwise, you may end up moving a register read and that could result in an incorrect shader. This commit fixes a rendering issue in Elite: Dangerous. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111152 Fixes: 3ee2e84c60 "nir: Rematerialize compare instructions" Reviewed-by: Matt Turner <mattst88@gmail.com> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Is there an easy way to cover this case with a piglit test? er, crucible test... (In reply to Mark Janes from comment #5) > Is there an easy way to cover this case with a piglit test? Can we write a test that will trigger this bug? Yes. Can we write one that will trigger it reliably across changes to other parts of the compiler? No way. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.