Bug 111549

Summary: 19.2.0_rc1 fails lp_test_arit, u_format_test, PIPE_FORMAT_DXT5_RGBA (unorm8)
Product: Mesa Reporter: erhard_f
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED MOVED QA Contact: mesa-dev
Severity: not set    
Priority: not set    
Version: 19.2   
Hardware: x86 (IA32)   
OS: All   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=110612
https://bugs.freedesktop.org/show_bug.cgi?id=109615
https://bugs.freedesktop.org/show_bug.cgi?id=106644
Whiteboard:
i915 platform: i915 features:
Attachments: Gentoo build.log.xz (19.2.0_rc1, x86)

Description erhard_f 2019-09-03 13:21:42 UTC
Created attachment 145252 [details]
Gentoo build.log.xz (19.2.0_rc1, x86)

# inxi -b
System:    Host: hakla04 Kernel: 5.2.11-gentoo i686 bits: 32 Console: tty 1 Distro: Gentoo Base System release 2.6 
Machine:   Type: Desktop System: Shuttle product: SN41V20 v: N/A serial: N/A 
           Mobo: Shuttle model: FN41V20 serial: N/A BIOS: Phoenix v: 6.00 PG date: 10/29/2004 
CPU:       Single Core: AMD Athlon XP 2600+ type: UP speed: 2080 MHz 
Graphics:  Device-1: Advanced Micro Devices [AMD/ATI] RV350 [Radeon 9550/9600/X1050 Series] driver: radeon v: kernel 
           Display: tty server: X.org 1.20.5 driver: ati,radeon unloaded: modesetting tty: 132x24 
           Message: Advanced graphics data unavailable in console for root. 
Network:   Device-1: NVIDIA nForce2 Ethernet driver: forcedeth 
           Device-2: Qualcomm Atheros AR5212/5213/2414 Wireless Network Adapter driver: ath5k 
Drives:    Local Storage: total: 279.48 GiB used: 6.73 GiB (2.4%) 
Info:      Processes: 112 Uptime: 5h 44m Memory: 1.96 GiB used: 192.0 MiB (9.6%) Init: systemd Shell: bash inxi: 3.0.34 

# lscpu 
Architecture:        i686
CPU op-mode(s):      32-bit
Byte Order:          Little Endian
Address sizes:       34 bits physical, 32 bits virtual
CPU(s):              1
On-line CPU(s) list: 0
Thread(s) per core:  1
Core(s) per socket:  1
Socket(s):           1
Vendor ID:           AuthenticAMD
CPU family:          6
Model:               8
Model name:          AMD Athlon(tm) XP 2600+
Stepping:            1
CPU MHz:             2079.583
BogoMIPS:            4160.46
L1d cache:           64K
L1i cache:           64K
L2 cache:            256K
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 mmx fxsr sse syscall mmxext 3dnowext 3dnow cpuid 3dnowprefetch vmmcall


[...]
Testing PIPE_FORMAT_DXT5_RGBA (unorm8) ...
round.v1(-0.5): ref = -0, out = -1, precision = -inf bits, FAIL
round.v1(0.5): ref = 0, out = 1, precision = -inf bits, FAIL
round.v4(-0.5): ref = -0, out = -1, precision = -inf bits, FAIL
round.v4(0.5): ref = 0, out = 1, precision = -inf bits, FAIL
[...]
Testing util_format_dxt1_rgb_unpack_rgba_8unorm ...
FAILED: {0x99, 0xb0, 0x8e, 0xff}, {0x5d, 0x62, 0x89, 0xff}, {0x99, 0xb0, 0x8e, 0xff}, {0x99, 0xb0, 0x8e, 0xff}, {0xd6, 0xff, 0x94, 0xff}, {0x5d, 0x62, 0x89, 0xff}, {0x99, 0xb0, 0x8e, 0xff}, {0xd6, 0xff, 0x94, 0xff}, {0x5d, 0x62, 0x89, 0xff}, {0x5d, 0x62, 0x89, 0xff}, {0x99, 0xb0, 0x8e, 0xff}, {0x21, 0x14, 0x84, 0xff}, {0x5d, 0x62, 0x89, 0xff}, {0x21, 0x14, 0x84, 0xff}, {0x21, 0x14, 0x84, 0xff}, {0x99, 0xb0, 0x8e, 0xff} obtained
        {0x98, 0xaf, 0x8e, 0xff}, {0x5c, 0x62, 0x88, 0xff}, {0x98, 0xaf, 0x8e, 0xff}, {0x98, 0xaf, 0x8e, 0xff}, {0xd6, 0xff, 0x94, 0xff}, {0x5c, 0x62, 0x88, 0xff}, {0x98, 0xaf, 0x8e, 0xff}, {0xd6, 0xff, 0x94, 0xff}, {0x5c, 0x62, 0x88, 0xff}, {0x5c, 0x62, 0x88, 0xff}, {0x98, 0xaf, 0x8e, 0xff}, {0x21, 0x13, 0x84, 0xff}, {0x5c, 0x62, 0x88, 0xff}, {0x21, 0x13, 0x84, 0xff}, {0x21, 0x13, 0x84, 0xff}, {0x98, 0xaf, 0x8e, 0xff} expected
Testing util_format_dxt1_rgba_unpack_rgba_8unorm ...
FAILED: {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90, 0xff}, {0x4e, 0xaa, 0x90, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90, 0xff}, {0x29, 0xff, 0xff, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90, 0xff}, {0x73, 0x55, 0x21, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90, 0xff}, {0x4e, 0xaa, 0x90, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xaa, 0x90, 0xff} obtained
        {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f, 0xff}, {0x4e, 0xa9, 0x8f, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f, 0xff}, {0x29, 0xff, 0xff, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f, 0xff}, {0x73, 0x54, 0x21, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f, 0xff}, {0x4e, 0xa9, 0x8f, 0xff}, {0x00, 0x00, 0x00, 0x00}, {0x00, 0x00, 0x00, 0x00}, {0x4e, 0xa9, 0x8f, 0xff} expected
Testing util_format_dxt3_rgba_unpack_rgba_8unorm ...
FAILED: {0x6d, 0xc6, 0x96, 0x77}, {0x6d, 0xc6, 0x96, 0xee}, {0x6d, 0xc6, 0x96, 0xaa}, {0x8c, 0xff, 0xb5, 0x44}, {0x6d, 0xc6, 0x96, 0xff}, {0x6d, 0xc6, 0x96, 0x88}, {0x31, 0x55, 0x5a, 0x66}, {0x6d, 0xc6, 0x96, 0x99}, {0x31, 0x55, 0x5a, 0xbb}, {0x31, 0x55, 0x5a, 0x55}, {0x31, 0x55, 0x5a, 0x11}, {0x6d, 0xc6, 0x96, 0xcc}, {0x6d, 0xc6, 0x96, 0xcc}, {0x6d, 0xc6, 0x96, 0x11}, {0x31, 0x55, 0x5a, 0x44}, {0x31, 0x55, 0x5a, 0x88} obtained
        {0x6c, 0xc6, 0x96, 0x77}, {0x6c, 0xc6, 0x96, 0xee}, {0x6c, 0xc6, 0x96, 0xa9}, {0x8c, 0xff, 0xb5, 0x43}, {0x6c, 0xc6, 0x96, 0xff}, {0x6c, 0xc6, 0x96, 0x87}, {0x31, 0x54, 0x5a, 0x66}, {0x6c, 0xc6, 0x96, 0x98}, {0x31, 0x54, 0x5a, 0xba}, {0x31, 0x54, 0x5a, 0x54}, {0x31, 0x54, 0x5a, 0x10}, {0x6c, 0xc6, 0x96, 0xcc}, {0x6c, 0xc6, 0x96, 0xcc}, {0x6c, 0xc6, 0x96, 0x10}, {0x31, 0x54, 0x5a, 0x43}, {0x31, 0x54, 0x5a, 0x87} expected
Testing util_format_dxt5_rgba_unpack_rgba_8unorm ...
FAILED: {0x6d, 0xc6, 0x96, 0x74}, {0x6d, 0xc6, 0x96, 0xf8}, {0x6d, 0xc6, 0x96, 0xb6}, {0x8c, 0xff, 0xb5, 0x53}, {0x6d, 0xc6, 0x96, 0xf8}, {0x6d, 0xc6, 0x96, 0x95}, {0x31, 0x55, 0x5a, 0x53}, {0x6d, 0xc6, 0x96, 0x95}, {0x31, 0x55, 0x5a, 0xb6}, {0x31, 0x55, 0x5a, 0x53}, {0x31, 0x55, 0x5a, 0x11}, {0x6d, 0xc6, 0x96, 0xd7}, {0x6d, 0xc6, 0x96, 0xb6}, {0x6d, 0xc6, 0x96, 0x11}, {0x31, 0x55, 0x5a, 0x32}, {0x31, 0x55, 0x5a, 0x95} obtained
        {0x6c, 0xc6, 0x96, 0x73}, {0x6c, 0xc6, 0x96, 0xf7}, {0x6c, 0xc6, 0x96, 0xb6}, {0x8c, 0xff, 0xb5, 0x53}, {0x6c, 0xc6, 0x96, 0xf7}, {0x6c, 0xc6, 0x96, 0x95}, {0x31, 0x54, 0x5a, 0x53}, {0x6c, 0xc6, 0x96, 0x95}, {0x31, 0x54, 0x5a, 0xb6}, {0x31, 0x54, 0x5a, 0x53}, {0x31, 0x54, 0x5a, 0x10}, {0x6c, 0xc6, 0x96, 0xd7}, {0x6c, 0xc6, 0x96, 0xb6}, {0x6c, 0xc6, 0x96, 0x10}, {0x31, 0x54, 0x5a, 0x31}, {0x31, 0x54, 0x5a, 0x95} expected
[...]
49/61 mesa:llvmpipe / lp_test_arit            FAIL     2.15 s (exit status 1)
56/61 mesa:gallium / u_format_test            FAIL     0.29 s (exit status 1)

Ok:                   59
Expected Fail:         0
Fail:                  2
Unexpected Pass:       0
Skipped:               0
Timeout:               0
Comment 1 erhard_f 2019-09-03 13:28:32 UTC
I decided to file this as new bug instead of adding my report to #110612, #109615 or #106644. It's a new mesa version, another machine and another arch (apart from #110612).

Though feel free to mark it as a duplicate if it makes more sense.
Comment 2 Roland Scheidegger 2019-09-05 21:38:51 UTC
This cpu doesn't support sse 4.1, and some of the fallbacks for rounding aren't quite kosher for the sake of simplicity / performance (I believe the format tests fail for similar reason).
I suppose it could be fixed albeit personally I think it makes a lot of sense to prioritize performance especially on such cpus.
Comment 3 erhard_f 2019-09-12 16:16:06 UTC
I prefer correctness over speed, as far as I am concerned. Also hard to distinguish if it's bad code or 'just fast code' when a test fails then. But I am not the one to decide.
Comment 4 Roland Scheidegger 2019-09-12 16:20:46 UTC
I guess it could be made switchable between fast and correct (like the gallivm filtering hacks). Honestly though I don't particularly care about such old x86 cpus so personally I wouldn't reject a patch switching it to correct...
Comment 5 GitLab Migration User 2019-09-18 20:33:23 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1047.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.