| Summary: | Mesa build breaks when only building radeonsi due to missing llvm coroutines symbols | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Shmerl <shtetldik> |
| Component: | Other | Assignee: | mesa-dev |
| Status: | RESOLVED MOVED | QA Contact: | mesa-dev |
| Severity: | normal | ||
| Priority: | not set | ||
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Patch to prevent build breakage on missing llvm coroutines | ||
Created attachment 145339 [details] [review] Patch to prevent build breakage on missing llvm coroutines Actually, I just tested, and it doesn't happen when building radv alone. So attaching a better fix. Hello Shmerl, this issue should have been fixed with https://gitlab.freedesktop.org/mesa/mesa/commit/8d286776b6ca177a5e55a9c706081a40ebbcf091 , did you encounter this with git master after that commit? (In reply to tele42k3 from comment #2) > Hello Shmerl, this issue should have been fixed with > https://gitlab.freedesktop.org/mesa/mesa/commit/ > 8d286776b6ca177a5e55a9c706081a40ebbcf091 , did you encounter this with git > master after that commit? Yes, I encountered it already after that commit. See attached patch. In particular, it happens when building for example only radeonsi and nothing else. Still happens on latest Mesa master. Should I make a MR in Gitlab for the fix? |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
When building only radeonsi and radv, Mesa builds fails like this: [1135/1135] Linking target src/gallium/targets/dri/libgallium_dri.so. FAILED: src/gallium/targets/dri/libgallium_dri.so g++-9 -o src/gallium/targets/dri/libgallium_dri.so <...> /usr/bin/ld: src/gallium/auxiliary/libgallium.a(gallivm_lp_bld_init.c.o): in function `init_gallivm_state': lp_bld_init.c:(.text+0x2ad): undefined reference to `LLVMAddCoroEarlyPass' /usr/bin/ld: lp_bld_init.c:(.text+0x2b6): undefined reference to `LLVMAddCoroSplitPass' /usr/bin/ld: lp_bld_init.c:(.text+0x2bf): undefined reference to `LLVMAddCoroElidePass' /usr/bin/ld: lp_bld_init.c:(.text+0x31d): undefined reference to `LLVMAddCoroCleanupPass' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. build failed! To fix, it, llvm coroutines module can be enabled for example like this: diff --git a/meson.build b/meson.build index 29d7981d13d..9ca40e3e896 100644 --- a/meson.build +++ b/meson.build @@ -1244,7 +1244,7 @@ endif llvm_modules = ['bitwriter', 'engine', 'mcdisassembler', 'mcjit'] llvm_optional_modules = [] if with_amd_vk or with_gallium_radeonsi or with_gallium_r600 - llvm_modules += ['amdgpu', 'native', 'bitreader', 'ipo'] + llvm_modules += ['amdgpu', 'native', 'bitreader', 'ipo', 'coroutines'] if with_gallium_r600 llvm_modules += 'asmparser' endif