Summary: | xf86-video-intel - Scrambled (text, graphics) of menu and text area in Libreoffice. | ||||||
---|---|---|---|---|---|---|---|
Product: | xorg | Reporter: | jb.1234abcd | ||||
Component: | Driver/intel | Assignee: | Chris Wilson <chris> | ||||
Status: | RESOLVED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||
Severity: | major | ||||||
Priority: | high | CC: | andyrtr | ||||
Version: | unspecified | ||||||
Hardware: | x86-64 (AMD64) | ||||||
OS: | Linux (All) | ||||||
Whiteboard: | |||||||
i915 platform: | i915 features: | ||||||
Attachments: |
|
Description
jb.1234abcd
2019-10-07 12:53:43 UTC
Please attach Xorg.0.log, you never know maybe there's something interesting there. Anyway, it sounds like one of the no-op compiler fixes caused a functional change, the fastest way to identify which one would be with a git bisect. diff --git a/src/sna/sna_io.c b/src/sna/sna_io.c index d32bd583f..d03280edb 100644 --- a/src/sna/sna_io.c +++ b/src/sna/sna_io.c @@ -465,13 +465,9 @@ fallback: } br13 = 0xcc << 16; - switch (cpp) { - default: - case 4: cmd |= BLT_WRITE_ALPHA | BLT_WRITE_RGB; - br13 |= 1 << 25; /* RGB8888 */ - case 2: br13 |= 1 << 24; /* RGB565 */ - case 1: break; - } + br13 |= sna_br13_color_depth(cpp * 4); + if (cpp == 4) + cmd |= BLT_WRITE_ALPHA | BLT_WRITE_RGB; This chunk, I guess. That cpp*4 should be cpp*8. commit bff5eca49b27cb47673123222a714d2a6f56287f (HEAD -> master, upstream/master) Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Oct 7 14:16:28 2019 +0100 sna: Scale cpp by 8 for bit depth Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111916 Fixes: 1804eacc85da ("sna: Add sna_br13_color_depth()") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> That's the only mistake I spotted in reading the git diff, so hopefully that's the one and only. Created attachment 145674 [details]
xorg.log with bad xf86-video-intel driver
(In reply to Chris Wilson from comment #4) > commit bff5eca49b27cb47673123222a714d2a6f56287f (HEAD -> master, > upstream/master) > Author: Chris Wilson <chris@chris-wilson.co.uk> > Date: Mon Oct 7 14:16:28 2019 +0100 > > sna: Scale cpp by 8 for bit depth > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111916 > Fixes: 1804eacc85da ("sna: Add sna_br13_color_depth()") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > That's the only mistake I spotted in reading the git diff, so hopefully > that's the one and only. Managed to reproduce this myself, and that commit does the trick. Thanks. I compiled the driver from source and that fixed the issue. Let's keep the bug report open for a few days until I get Arch Linux to rebuild the package, and if OK then I will close it. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.